Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCL5815 - Updates for JDK11 #801

Merged
merged 7 commits into from
Nov 25, 2020
Merged

NCL5815 - Updates for JDK11 #801

merged 7 commits into from
Nov 25, 2020

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Oct 30, 2020

No description provided.

@rnc rnc changed the title Ncl 5815 NCL5815 - Updates for JDK11 Oct 30, 2020
@rnc rnc requested a review from dwalluck October 30, 2020 15:57
@rnc rnc force-pushed the NCL-5815 branch 6 times, most recently from 19a42c6 to 97a0fb3 Compare November 3, 2020 14:12
@rnc rnc marked this pull request as ready for review November 3, 2020 20:20
@release-engineering release-engineering deleted a comment from codecov bot Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #801 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #801      +/-   ##
============================================
+ Coverage     83.13%   83.21%   +0.08%     
- Complexity     1855     1860       +5     
============================================
  Files           115      115              
  Lines          6931     6935       +4     
  Branches       1209     1209              
============================================
+ Hits           5762     5771       +9     
  Misses          679      679              
+ Partials        490      485       -5     
Impacted Files Coverage Δ Complexity Δ
...commonjava/maven/ext/common/json/ErrorMessage.java 50.00% <ø> (ø) 2.00 <0.00> (ø)
...va/maven/ext/common/json/ExtendedLookupReport.java 66.66% <ø> (ø) 3.00 <0.00> (ø)
...rg/commonjava/maven/ext/common/util/JSONUtils.java 95.74% <ø> (ø) 3.00 <0.00> (ø)
.../commonjava/maven/ext/common/util/WildcardMap.java 96.15% <ø> (ø) 20.00 <0.00> (ø)
...va/org/commonjava/maven/ext/core/impl/Version.java 85.48% <ø> (ø) 70.00 <0.00> (ø)
...commonjava/maven/ext/core/util/PropertyMapper.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...org/commonjava/maven/ext/common/model/Project.java 87.01% <0.00%> (-1.30%) 85.00% <0.00%> (ø%)
...va/maven/ext/io/resolver/GalleyInfrastructure.java 85.18% <0.00%> (-0.27%) 15.00% <0.00%> (ø%)
...ommonjava/maven/ext/core/util/PropertiesUtils.java 85.92% <0.00%> (+0.07%) 58.00% <0.00%> (ø%)
...mmonjava/maven/ext/core/impl/RESTBOMCollector.java 87.27% <0.00%> (+0.23%) 17.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c14522...f83c274. Read the comment docs.

@rnc rnc marked this pull request as draft November 4, 2020 07:37
@rnc
Copy link
Contributor Author

rnc commented Nov 4, 2020

I've marked this as draft again as it appears coverage isn't being tracked with jdk11 - its not codecov as I can reproduce locally with plain jacoco.

@rnc rnc marked this pull request as ready for review November 4, 2020 11:21
@rnc rnc mentioned this pull request Nov 4, 2020
@vibe13
Copy link
Contributor

vibe13 commented Nov 11, 2020

Hi @rnc it looks good to me!

@rnc rnc merged commit ce0230c into release-engineering:master Nov 25, 2020
@rnc rnc deleted the NCL-5815 branch November 25, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants