Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCLSUP-209 Detect running in container to disable log file #808

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Dec 1, 2020

No description provided.

@rnc rnc requested a review from vibe13 December 1, 2020 12:58
@rnc rnc force-pushed the NCLSUP209 branch 3 times, most recently from 18f8a60 to 33e83eb Compare December 1, 2020 15:14
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #808 (d21b5af) into master (e990ae0) will decrease coverage by 0.01%.
The diff coverage is 89.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #808      +/-   ##
============================================
- Coverage     83.27%   83.26%   -0.02%     
- Complexity     1865     1871       +6     
============================================
  Files           115      115              
  Lines          6937     6950      +13     
  Branches       1210     1212       +2     
============================================
+ Hits           5777     5787      +10     
- Misses          679      681       +2     
- Partials        481      482       +1     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/commonjava/maven/ext/cli/Cli.java 82.19% <89.28%> (-0.39%) 35.00 <5.00> (+6.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e990ae0...d21b5af. Read the comment docs.

Copy link
Contributor

@vibe13 vibe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Nick! Thanks for this improvement!

@rnc rnc merged commit 455b8a8 into release-engineering:master Dec 2, 2020
@rnc rnc deleted the NCLSUP209 branch December 2, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants