Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCL-6697 Handle artifactId/groupId being property expressions. Add pluginRelocation functionality #868

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Aug 6, 2021

Fixes #867

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #868 (57374b5) into master (032836f) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

❗ Current head 57374b5 differs from pull request most recent head af8c750. Consider uploading reports for the commit af8c750 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #868      +/-   ##
============================================
- Coverage     83.84%   83.83%   -0.01%     
- Complexity     1870     1878       +8     
============================================
  Files           115      115              
  Lines          6908     6935      +27     
  Branches       1198     1200       +2     
============================================
+ Hits           5792     5814      +22     
- Misses          648      649       +1     
- Partials        468      472       +4     
Impacted Files Coverage Δ
...mmonjava/maven/ext/core/state/RelocationState.java 92.10% <90.00%> (-2.02%) ⬇️
...ava/maven/ext/core/impl/RelocationManipulator.java 89.65% <91.07%> (-0.35%) ⬇️
...a/maven/ext/io/resolver/MavenLocationExpander.java 75.45% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032836f...af8c750. Read the comment docs.

@rnc rnc changed the title NCL-6697 Handle artifactId/groupId being property expressions. Start … NCL-6697 Handle artifactId/groupId being property expressions. Add pluginRelocation functionality Aug 7, 2021
@rnc rnc marked this pull request as ready for review August 7, 2021 14:38
@rnc rnc force-pushed the NCL6697 branch 2 times, most recently from feafc59 to 4fb24cc Compare August 7, 2021 20:24
@rnc rnc force-pushed the NCL6697 branch 2 times, most recently from 57374b5 to d5cca8a Compare August 10, 2021 13:30
@rnc rnc force-pushed the NCL6697 branch 2 times, most recently from 1b95b0f to fedf29e Compare August 10, 2021 14:51
@rnc rnc merged commit ba713f5 into release-engineering:master Aug 10, 2021
@rnc rnc deleted the NCL6697 branch August 11, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependencyRelocation ignores properties used for groupId and artifactId and does not work for plugins
2 participants