Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for optional overwrite of pom files. Code refactor #970

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Mar 29, 2023

Fixes #965

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 86.36% and project coverage change: +0.03 🎉

Comparison is base (46a5d76) 83.81% compared to head (4803de1) 83.84%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #970      +/-   ##
============================================
+ Coverage     83.81%   83.84%   +0.03%     
- Complexity     1947     1948       +1     
============================================
  Files           120      120              
  Lines          7187     7182       -5     
  Branches       1230     1228       -2     
============================================
- Hits           6024     6022       -2     
+ Misses          675      674       -1     
+ Partials        488      486       -2     
Impacted Files Coverage Δ
...commonjava/maven/ext/core/ManipulationManager.java 88.88% <83.33%> (-0.31%) ⬇️
...mmonjava/maven/ext/manip/ManipulatingEventSpy.java 81.57% <100.00%> (+5.49%) ⬆️
...ain/java/org/commonjava/maven/ext/io/ConfigIO.java 72.34% <100.00%> (ø)
...c/main/java/org/commonjava/maven/ext/io/PomIO.java 90.30% <100.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rnc rnc marked this pull request as ready for review March 30, 2023 07:44
@rnc rnc merged commit 5e7d90a into release-engineering:main Jul 3, 2023
@rnc rnc deleted the ISSUE965 branch July 3, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwriting pom file should be optional
1 participant