fix(gitlab): don't set Content-Type header when uploading release assets #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in [a comment on release-it#1172][1], switching to the use of the native fetch API broken uploading release assets to GitLab by hard-coding the Content-Type header to "text/plain". The [recommended approach][2] is to avoid setting the Content-Type header at all and let the fetch API implementation set it so as to ensure that the correct boundary expression is included. Update the `request` function to only set the Content-Type header when body is not an instance of FormData. The default behaviour is to set the header as before. [1]: release-it#1172 (comment) [2]: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest_API/Using_FormData_Objects#sending_files_using_a_formdata_object Closes release-it#1172
rjw57
force-pushed
the
fix-release-assets-gitlab
branch
from
856d375 to
b474bc3
Compare
commit: |
|
🚀 This pull request is included in v18.0.0-next.4. See Release 18.0.0-next.4 for release notes. |
|
🚀 This pull request is included in v17.11.0. See Release 17.11.0 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in a comment on #1172, switching to the use of the native fetch API broke uploading release assets to GitLab by hard-coding the Content-Type header to "text/plain". The recommended approach is to avoid setting the Content-Type header at all and let the fetch API implementation set it so as to ensure that the correct boundary expression is included.
Add a flag to theUpdate therequestfunction to allow explicitly disabling setting the Content-Type header.requestfunction to avoid setting the Content-Type header if the body is an instance ofFormData. The default behaviour is to set the header as before but we disable setting the header only in theuploadAssetfunction.The bug is blocking a feature in our product and I've checked that the change in this PR fixes our observed issue with GitLab release asset uploads. Using the branch from this PR, I am able to create a release with the expected assets in a test project.
Closes #1172