Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lc refactor #221

Merged
merged 189 commits into from
Feb 16, 2021
Merged

Lc refactor #221

merged 189 commits into from
Feb 16, 2021

Conversation

rhe-reliatec
Copy link
Member

@rhe-reliatec rhe-reliatec commented Feb 16, 2021 •
edited by oba-reliatec
Loading

eliminates ~ 12000 warnings, mostly "... is a raw type.", "... is not used", "... is never used locally", "StringUtil is deprecated"
~ 9600 less code lines

@chae-reliatec
refactored StudyEventDefinitionBean.java
9f7fccf 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
removed unused imports
2a3d876 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed warning: 'Comparable is a raw type.'
be0b539 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed warning: 'ArrayList is a raw type.' for **/*.Row.java
e986eea 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed warning: 'ArrayList is a raw type.' for beans
4a47158 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed warning: 'The serializable class ... does not declare a static …
0088a3b 
…final serialVersionUID field of type long'

Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed warning: 'The value of the (field/local variable) is not used'
6f81be7 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed warning: 'The value of the (field/local variable) is not used'
8acb67e 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings
c188d2f 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed warning 'The type|constructor|method ... is never used locally'
a03ff94 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed warning: 'Overriding managed version ...'
9aaa3be 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for EntityDAO
b5d8ebd 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for AuditableEntityDAO (and resulting issues)
2106c77 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
Merge branch 'lc-develop' into lc-refactor
cb36a25
@chae-reliatec
fixed different warnings for ArchivedDatasetFileDAO
5baf8cc 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
made methods create and update generic for DAOInterface
8cd3975 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for AuditEventDAO
79d72a5 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for CRFDAO
5c991ba 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for CRFVersionDAO
e5baed8 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
made EntityDAO::executeFindByPKQuery generic
4b1aee3 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
made EntityDAO::executeFindByPKQuery generic
30a1a4f 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for DatasetDAO
3fe7b6e 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for OdmExtractDAO
a87972f 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for SectionDAO
dd36d9e 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for DiscrepancyNoteDAO
373f162 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
used UserAccountDAO from AuditableEntityDAO instead of creating a new…
9b152ba 
… instance

Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for EventCRFDAO
8b9abf2 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
added methods 'listToString' and 'listFromString' to NullValue
e5f35a6 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for EventDefinitionCRFDAO
fab80af 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for ExpressionDAO
a8c67b7 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
chae-reliatec and others added 22 commits January 4, 2021 16:56
@chae-reliatec
fixed different warnings for package org.akaza.openclinica.web.filter
0ed58cb 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for package org.akaza.openclinica.web.job
1688010 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for package org.akaza.openclinica.ws
7df13b2 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for package org.akaza.openclinica.ws
76f1c14 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed different warnings for package org.akaza.openclinica.ws.*
8a1cdaa 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed issue with openclinica version delete query
f085458 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed issue in method 'getValidOid'
4b28cae 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed issue with return type of query
8ac8bd0 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
added a custom comparator for EntityBeanRow
7beba2a 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed issue in method 'getValidOid'
c44c5cb 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@rhe-reliatec
Removed registration of obsolete dao.
b01e89f
@rhe-reliatec
Removed escaping of backslashes. This does not work with Postgres9.
d0950e9 
See: #184
@chae-reliatec
added variations for method executeUpdate that do not fail when nothi…
a87b12d 
…ng is updated
@chae-reliatec
fixed issue with method setSysAdminRole
16e66f2 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed issue with method findByStudySubject
aa955ba 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed issue with expected types in AuditDAO
6be4eb1 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
fixed issue with method findAllTopNotesByEventCRF for DiscrepancyNoteDAO
199fd80 
Signed-off-by: Christian Hänsel <chae.reliatec@googlemail.com>
@chae-reliatec
changed log level from warning to debug for 'found no object for quer…
2db9825 
…y ...'
@rhe-reliatec
Linefeeds.
9cb064b 
All files have now crlf as lineendings.
@rhe-reliatec
Merge branch 'lc-refactor' of https://github.com/reliatec-gmbh/LibreC…
2495639 
…linica into lc-refactor
@rhe-reliatec
There was a formatting error in logger messages.
e43fd41 
Replaced things like %s with {}.
@rhe-reliatec
Changed datatypes for date_start, date_end.
3121f41
This was linked to issues Feb 16, 2021
Item validator regular expression \ escapes broken in PostgresSQL 9.x #184
Closed
remove duplicate classes from classpath #197
Closed
@rhe-reliatec rhe-reliatec merged commit 80c97f8 into lc-develop Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oba-reliatec oba-reliatec

@rhe-reliatec rhe-reliatec

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rhe-reliatec @oba-reliatec @chae-reliatec