Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement for assertion call and usages #29

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the * to let all branch name can be triggered on GitHub Actions.
  • Remove $settings variable because it's assigned, but not used.
  • Using the assertNull to assert expected is null.
  • Using the assertFalse to assert expected is false.
  • Using the assertTrue to assert expected is true.
  • According to the PHPUnit fixtures reference, the setUp method is protected function setUp(): void and the tearDown method is protected function teaDown(): void.

Copy link
Member

@sj-i sj-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sj-i sj-i merged commit 496e6fc into reliforp:master Aug 15, 2020
@sj-i
Copy link
Member

sj-i commented Aug 15, 2020

thanks!

@peter279k peter279k deleted the test_enhancement branch August 15, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants