Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output the cause of the error when an error occurs at converters #364

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Output the cause of the error when an error occurs at converters #364

merged 1 commit into from
Nov 25, 2023

Conversation

sj-i
Copy link
Member

@sj-i sj-i commented Nov 25, 2023

No description provided.

@sj-i sj-i added the enhancement New feature or request label Nov 25, 2023
@sj-i sj-i added this to the 0.10.0 milestone Nov 25, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6990525099

  • 0 of 67 (0.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 83.328%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Converter/PhpSpyCompatibleDataContext.php 0 2 0.0%
src/Converter/PhpSpyCompatibleParser.php 0 21 0.0%
src/Converter/Speedscope/SpeedscopeConverter.php 0 44 0.0%
Files with Coverage Reduction New Missed Lines %
src/Converter/PhpSpyCompatibleParser.php 2 0.0%
Totals Coverage Status
Change from base Build 6990521237: -0.9%
Covered Lines: 4868
Relevant Lines: 5842
💛 - Coveralls

@sj-i sj-i merged commit 7bc890e into 0.10.x Nov 25, 2023
6 checks passed
@sj-i sj-i deleted the improve-speedscope-converter branch November 25, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sj-i @coveralls