Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration option to the speedscope converter for the handling of utf8 errors #365

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

sj-i
Copy link
Member

@sj-i sj-i commented Nov 25, 2023

No description provided.

@sj-i sj-i added the enhancement New feature or request label Nov 25, 2023
@sj-i sj-i added this to the 0.10.0 milestone Nov 25, 2023
@sj-i sj-i merged commit 961e084 into 0.10.x Nov 25, 2023
6 checks passed
@sj-i sj-i deleted the improve-speedscope-converter branch November 25, 2023 19:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6990981554

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 20 (0.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 83.043%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Converter/Speedscope/Settings/SpeedscopeConverterSettings.php 0 1 0.0%
src/Converter/Speedscope/SpeedscopeConverter.php 0 1 0.0%
src/Converter/Speedscope/Settings/Utf8ErrorHandlingType.php 0 5 0.0%
src/Converter/Speedscope/Settings/SpeedscopeConverterSettingsFromConsoleInput.php 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
src/Lib/PhpProcessReader/PhpZendMemoryManagerChunkFinder.php 1 83.33%
Totals Coverage Status
Change from base Build 6990528163: -0.3%
Covered Lines: 4868
Relevant Lines: 5862

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants