Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix a sample code #408

Merged
merged 1 commit into from
Jan 17, 2024
Merged

doc: fix a sample code #408

merged 1 commit into from
Jan 17, 2024

Conversation

nsfisis
Copy link
Contributor

@nsfisis nsfisis commented Jan 17, 2024

I fixed a sample code to make it work with declare(strict_types=1).

escapeshellarg() only accepts string with strict type checking enabled.

@nsfisis
doc: fix a sample code
db9073a 
`escapeshellarg()` only accepts `string` if `strict_types` is 1.
@sj-i sj-i added the documentation Improvements or additions to documentation label Jan 17, 2024
@sj-i sj-i added this to the 0.10.4 milestone Jan 17, 2024
@sj-i sj-i merged commit 0a96983 into reliforp:0.12.x Jan 17, 2024
@sj-i sj-i modified the milestones: 0.10.4, 0.11.3 Jan 17, 2024
@nsfisis nsfisis deleted the fix/doc-sample-code branch January 17, 2024 13:33
@sj-i
Copy link
Member

sj-i commented Jan 17, 2024

@nsfisis Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nsfisis @sj-i