Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the target PHP version detection on some cases #422

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Fix the target PHP version detection on some cases #422

merged 1 commit into from
Jan 27, 2024

Conversation

sj-i
Copy link
Member

@sj-i sj-i commented Jan 27, 2024

The automatically detected PHP version isn't actually used to get the address of EG and CG on i:m and i:eg

@sj-i
Fix the target PHP version detection on some cases
5d0abad 
The automatically detected PHP version isn't actually used to get the address of EG and CG on i:m and i:eg
@sj-i sj-i added the bug Something isn't working label Jan 27, 2024
@sj-i sj-i added this to the 0.11.4 milestone Jan 27, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7676071297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.163%
Totals Coverage Status
Change from base Build 7573526597: 0.02%
Covered Lines: 5155
Relevant Lines: 6125
💛 - Coveralls

@sj-i sj-i merged commit d83f8a5 into 0.11.x Jan 27, 2024
6 checks passed
@sj-i sj-i deleted the fix-version-detection branch January 27, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@sj-i @coveralls