Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure namespaces #7

Merged
merged 6 commits into from
May 21, 2020
Merged

Restructure namespaces #7

merged 6 commits into from
May 21, 2020

Conversation

sj-i
Copy link
Member

@sj-i sj-i commented May 21, 2020

  • move UInt64 into a namespace
  • rename ProcessReader to PhpProcessReader, also move it into Lib
  • rename BinaryReader to LittleEndianReader
  • add an interface IntegerByteSequenceReader to LittleEndianReader, also move them into a namespace
  • move construction of LittleEndianReader to DI container
  • rename namespace Binary to ByteStream

@sj-i sj-i merged commit fc6b0c4 into master May 21, 2020
@sj-i sj-i deleted the restructure_namespaces branch May 28, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sj-i