Revised Virtual Memory #45

jdonszelmann · 2020-03-05T14:17:07Z

No description provided.

Co-authored-by: Victor Roest <victor@xirion.net>

make panic exit codes more obvious.

Co-authored-by: Victor Roest <victor@xirion.net>

Co-authored-by: Jonathan Dönszelmann <jonabent@gmail.com>

* Resolved easy TODOs where possible * Converted `panic` calls to `FATAL` (for better logging) * Resolved some code analysis issues CLion flagged

.gitignore

kernel/src/allocator/llist.c

kernel/src/allocator/mem_alloc.c

kernel/src/common/hardwareinfo.c

kernel/src/common/interrupt.c

kernel/src/vm/vas2.c

kernel/src/vm/vm2.c

Co-authored-by: Victor Roest <victor@xirion.net>

…om the OS pagetable. This saves 8KiB (!) per process. It also makes caching more efficient. Co-authored-by: Jonathan Dönszelmann <jonabent@gmail.com>

NULLx76 · 2020-03-10T12:16:46Z

@dsluijk I think we addressed most if not all of your issues, if you could look at the changes again that would be appreciated.

And removed some unused header files.

.github/workflows/os_test.yml

kernel/Makefile

kernel/src/fs/path.c

timanema

I'll try and test it later. Apart from some very minor things it looks good!

timanema · 2020-03-10T15:31:32Z

kernel/src/common/stacks.s

+
+    // Switch back SVC/Kernel
+    MSR CPSR_c, #Mode_SVC
+    ADD fp, sp, #0 // ???


What the difference with a regular mov here?

I do not know, this was there in the original ~~and I'm too scared to change it~~

according to 10 minutes of research it's faster nor different to a simple mov. Compilers may generate it as part of a function header to help debuggers identify them. the #0 can be replaced by n for n variables in the stackframe. In this position it's confusing and useless and can be replaced by a simple mov.

2 more minutes of research found that add is actually faster in 1 nonsequential cycle.
paraphrased from the arm manual:

The data operations ADD, SUB, RSB, ADC, SBC are 2S + 1I while RSC, ORR, EOR, MOV, BIC are 2S + 1N + 1I where I means internal cycle, N means nonsequential cycle and S means sequential cycle

Shouldn't make much of a difference here though, and is mostly confusing

should be a mov imo

kernel/src/vm/vm2.c

dsluijk

LGTM

Revised Virtual Memory

jdonszelmann and others added 3 commits March 3, 2020 11:39

made sure printf works even before uart is initialized

da8d5ee

slice allocator works

2a0f78b

Co-authored-by: Victor Roest <victor@xirion.net>

checkpoint!

d1b904e

Co-authored-by: Victor Roest <victor@xirion.net>

NULLx76 mentioned this pull request Mar 6, 2020

Virtual Memory #25

Closed

NULLx76 assigned NULLx76 and jdonszelmann Mar 6, 2020

NULLx76 linked an issue Mar 6, 2020 that may be closed by this pull request

Virtual Memory #25

Closed

jdonszelmann and others added 2 commits March 8, 2020 14:18

Vm WoRkS aAaAaAaAaAaAaA

c540860

Co-authored-by: Victor Roest <victor@xirion.net>

Cleaned up source

6e79bbc

Co-authored-by: Victor Roest <victor@xirion.net>

NULLx76 changed the title ~~Newvm~~ Revised Virtual Memory Mar 8, 2020

jdonszelmann force-pushed the newvm branch from 23f14f8 to 2307bc6 Compare March 8, 2020 16:14

enabled high interrupt vectors to enable higher-half interrupts

29c0a89

Co-authored-by: Victor Roest <victor@xirion.net>

jdonszelmann force-pushed the newvm branch 2 times, most recently from 29c0a89 to 952cda6 Compare March 8, 2020 16:20

enabled high interrupt vectors to enable higher-half interrupts

401470f

Co-authored-by: Victor Roest <victor@xirion.net>

jdonszelmann force-pushed the newvm branch from 952cda6 to 401470f Compare March 8, 2020 16:23

Victor Roest and others added 5 commits March 8, 2020 17:28

Merge branch 'newvm' of github.com:rellermeyer/course_os into newvm

55141ee

Disable toolchain cache, to see if it fixs CI

29253eb

Added tlb_cache_id_allocator tests and comments

be99ff8

Added Semihosting call to exit with an arbitrary exit code, this should

82c027e

make panic exit codes more obvious.

hopefully fixed CI by building qemu ourselves

d2e7052

Co-authored-by: Victor Roest <victor@xirion.net>

jdonszelmann force-pushed the newvm branch from d568c7b to d2e7052 Compare March 9, 2020 09:28

jdonszelmann and others added 2 commits March 9, 2020 10:30

fixed ci script

7e0ea6f

Co-authored-by: Victor Roest <victor@xirion.net>

Fixed heap init and randomized test order

51fcf51

Co-authored-by: Jonathan Dönszelmann <jonabent@gmail.com>

NULLx76 marked this pull request as ready for review March 9, 2020 11:14

NULLx76 requested review from dsluijk, Zedfrigg and timanema March 9, 2020 11:15

Cleanup codebase

96c485c

* Resolved easy TODOs where possible * Converted `panic` calls to `FATAL` (for better logging) * Resolved some code analysis issues CLion flagged

dsluijk requested changes Mar 9, 2020

View reviewed changes

jdonszelmann and others added 7 commits March 9, 2020 15:07

added fatals in interrupt.c for invalid interrupt mask

cfa2050

merge

6c634c8

added runconfigs to git

9a9e99e

renamed l1_in_l2 to find_l2pt

53c4be6

changed fatals to warns in interrupt.c

3ffb246

Added vscode run config

27bbc83

Cleaned up gitignore

8aecf6a

NULLx76 linked an issue Mar 10, 2020 that may be closed by this pull request

GDB Support #11

Closed

NULLx76 mentioned this pull request Mar 10, 2020

GDB Support #11

Closed

NULLx76 linked an issue Mar 10, 2020 that may be closed by this pull request

GDB Breakpoint Support #12

Closed

jdonszelmann and others added 3 commits March 10, 2020 10:48

updated vas2.c. Has to be tested with a scheduler but is pretty complete

79ed90d

Co-authored-by: Victor Roest <victor@xirion.net>

Merge branch 'newvm' of github.com:rellermeyer/course_os into newvm

1a39b69

Switched to a memory model where the Process pagetable is separate fr…

b91078e

…om the OS pagetable. This saves 8KiB (!) per process. It also makes caching more efficient. Co-authored-by: Jonathan Dönszelmann <jonabent@gmail.com>

NULLx76 requested a review from dsluijk March 10, 2020 12:15

NULLx76 added the task label Mar 10, 2020

NULLx76 added this to the Virtual Memory milestone Mar 10, 2020

Victor Roest added 2 commits March 10, 2020 13:51

Removed outdated TODO

5cdd28d

Added more docs

ccdfcc1

And removed some unused header files.

NULLx76 requested a review from redshiftss March 10, 2020 15:09

Added debug runconfig

473f75c

redshiftss approved these changes Mar 10, 2020

View reviewed changes

.github/workflows/os_test.yml Show resolved Hide resolved

kernel/Makefile Outdated Show resolved Hide resolved

kernel/src/fs/path.c Show resolved Hide resolved

timanema reviewed Mar 10, 2020

View reviewed changes

jdonszelmann mentioned this pull request Mar 10, 2020

New readme #49

Closed

dsluijk approved these changes Mar 11, 2020

View reviewed changes

NULLx76 merged commit 28bb277 into refactor Mar 11, 2020

NULLx76 deleted the newvm branch March 11, 2020 10:39

NULLx76 mentioned this pull request Mar 11, 2020

GDB Breakpoint Support #12

Closed

NULLx76 added a commit that referenced this pull request Nov 29, 2024

Merge pull request #45 from rellermeyer/newvm

3361b45

Revised Virtual Memory

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revised Virtual Memory #45

Revised Virtual Memory #45

jdonszelmann commented Mar 5, 2020

NULLx76 commented Mar 10, 2020

timanema left a comment

timanema Mar 10, 2020

NULLx76 Mar 10, 2020

jdonszelmann Mar 10, 2020

jdonszelmann Mar 10, 2020 •

edited

Loading

jdonszelmann Mar 10, 2020

dsluijk left a comment

Revised Virtual Memory #45

Revised Virtual Memory #45

Conversation

jdonszelmann commented Mar 5, 2020

NULLx76 commented Mar 10, 2020

timanema left a comment

Choose a reason for hiding this comment

timanema Mar 10, 2020

Choose a reason for hiding this comment

NULLx76 Mar 10, 2020

Choose a reason for hiding this comment

jdonszelmann Mar 10, 2020

Choose a reason for hiding this comment

jdonszelmann Mar 10, 2020 • edited Loading

Choose a reason for hiding this comment

jdonszelmann Mar 10, 2020

Choose a reason for hiding this comment

dsluijk left a comment

Choose a reason for hiding this comment

jdonszelmann Mar 10, 2020 •

edited

Loading