Encoder support for KeyboardModel and some classes #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoichiro
force-pushed
the
encoder-support-for-keyboard-model
branch
from
f9cda89
to
4d7e3d0
Compare
yoichiro
force-pushed
the
encoder-support-for-keyboard-model
branch
from
4d7e3d0
to
2cd1026
Compare
|
@adamrocker Could you review this pull request? I would like to confirm whether this approach looks good to your idea or not. |
adamrocker
reviewed
Sep 12, 2022
src/models/KeyboardModel.ts
Outdated
| @@ -101,6 +102,13 @@ class KeymapItem { | |||
| this.option = options[0]; | |||
| this.choice = options[1]; | |||
| this._toBeDelete = false; | |||
| // Check whether this key is an encoder or not | |||
| const positions = label.split('\n'); | |||
There was a problem hiding this comment.
I think you might integrate this code to line#100 which is the splitter of contents in a label.
There was a problem hiding this comment.
@adamrocker I refactored the logic, and I removed the pos instance variable because it is not used. Could you review them again? The diff is 8e714d7.
|
Your approach looks perfect. I agree with this. |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #201
This pull request adds a new feature to support encoders for
KeyboardModeland some other classes. For instance, if some keys have an encoder ID in the VIA JSON file, theKeyboardModelobject provides whether the key has an encoder ID or not.