fix: bump up html-dom-parser to handle carriage return #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarkablemark
added
bug
| @@ -49,7 +49,7 @@ | |||
| ], | |||
| "dependencies": { | |||
| "domhandler": "5.0.3", | |||
| "html-dom-parser": "5.0.10", | |||
| "html-dom-parser": "5.0.11", | |||
There was a problem hiding this comment.
Don't forget to update package-lock.json as well
There was a problem hiding this comment.
@kingflamez the html-dom-parser package has been released:
After updating the lockfile, could I get your help in adding a test?
There was a problem hiding this comment.
Heads up, I'll be merging #1623 so we can close this PR. Thanks for your help on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Bug fix
What is the current behavior?
Addresses html-dom-parser #420
Fixes #864
What is the new behavior?
Checklist: