Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.json not defined by exports warning #522

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

LivDunn
Copy link
Contributor

@LivDunn LivDunn commented Apr 22, 2022

What is the motivation for this pull request?

Fix warning with package when running react-native

bug fix

What is the current behavior?

react-native-community/cli#1168 - When running react-native under Node.js 14.x on a project that uses npm modules which specify the new exports field in package.json, react-native will throw a warning of
warn Package html-react-parser has been ignored because it contains invalid configuration. Reason: Package subpath './package.json' is not defined by "exports" in /PATH_TO_CURRENT_PROJECT/node_modules/html-react-parser/package.json

What is the new behavior?

Warning no longer appears and package runs correctly

Checklist:

@LivDunn LivDunn marked this pull request as ready for review April 22, 2022 20:37
Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@remarkablemark remarkablemark merged commit ed89b4d into remarkablemark:master Apr 22, 2022
@remarkablemark remarkablemark added the bug Something isn't working label Apr 22, 2022
@remarkablemark
Copy link
Owner

Released #523 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants