Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tests for tables #664

Closed
wants to merge 1 commit into from
Closed

update tests for tables #664

wants to merge 1 commit into from

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

discovered in micromark/micromark#106
the unit tests no longer align with how tables are styled

@ChristianMurphy ChristianMurphy added the 🕸️ area/tests This affects tests label Dec 13, 2021
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 13, 2021
@ChristianMurphy
Copy link
Member Author

Good news, the tests pass now

 test.jsx
• • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • •   (96 / 96)

  Total:     96
  Passed:    96
  Skipped:   0
  Duration:  419.48ms

bad news, the test coverage has dropped?

ERROR: Coverage for lines (99.72%) does not meet global threshold (100%)
ERROR: Coverage for branches (99.45%) does not meet global threshold (100%)
ERROR: Coverage for statements (99.72%) does not meet global threshold (100%)

I find this strange since it doesn't add logic, or remove tests, the coverage should be the same as before?

wooorm
wooorm reviewed Dec 16, 2021
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, who is adding text-align:none? 🤔

@ChristianMurphy
Copy link
Member Author

Just based off timing I suspect https://github.com/micromark/micromark-extension-gfm-table/releases/tag/1.0.5

@wooorm
Copy link
Member

wooorm commented Dec 16, 2021

Could be, but feels slightly unexpected to me? could it be react related? 🤔

@ChristianMurphy
Copy link
Member Author

React was last updated in March, and tests have passed several times in that time span 🤔
https://github.com/facebook/react/releases/tag/v17.0.2

@ChristianMurphy
Copy link
Member Author

cross linking a related issue remarkjs/remark-gfm#29

@wooorm
Copy link
Member

wooorm commented Dec 19, 2021

weird, will look into it soon

@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added 👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on labels Dec 21, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 21, 2021
@wooorm
Copy link
Member

wooorm commented Dec 21, 2021

The original tests is how it should be

@ChristianMurphy ChristianMurphy deleted the update-table-tests branch December 21, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm left review comments

Assignees
No one assigned
Labels
🕸️ area/tests This affects tests 👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianMurphy @wooorm