Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig.json to use node16 module resolution #1106

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

use node16 module resolution in typescript.
Scope JSON module resolution to just the CLI where it is used.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1106 (02b5161) into main (f07f413) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          906       906           
=========================================
  Hits           906       906           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07f413...02b5161. Read the comment docs.

@ChristianMurphy
Copy link
Member Author

Ongoing discussion on the approach at rehypejs/rehype#123

@wooorm wooorm changed the title types: use node16 module resolution in typescript Update tsconfig.json to use node16 module resolution Jan 17, 2023
@wooorm wooorm merged commit bec44aa into remarkjs:main Jan 17, 2023
@wooorm wooorm added ☂️ area/types This affects typings 💪 phase/solved Post is done labels Jan 17, 2023
@wooorm
Copy link
Member

wooorm commented Jan 17, 2023

Thanks!

@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 17, 2023
@ChristianMurphy ChristianMurphy deleted the types/node16 branch January 17, 2023 12:42
tylersmalley referenced this pull request in tailscale-dev/tailscale-dev Jun 5, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [remark](https://remark.js.org)
([source](https://github.com/remarkjs/remark)) | [`^14.0.2` ->
`^14.0.3`](https://renovatebot.com/diffs/npm/remark/14.0.2/14.0.3) |
[![age](https://badges.renovateapi.com/packages/npm/remark/14.0.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/remark/14.0.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/remark/14.0.3/compatibility-slim/14.0.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/remark/14.0.3/confidence-slim/14.0.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>remarkjs/remark</summary>

###
[`v14.0.3`](https://github.com/remarkjs/remark/releases/tag/14.0.3)

[Compare
Source](https://github.com/remarkjs/remark/compare/14.0.2...14.0.3)

##### Misc

-   Rerelease types for changes in TypeScript

[https://github.com/remarkjs/remark/issues/1162](https://github.com/remarkjs/remark/issues/1162)1162
- [`f6bd64e`](https://github.com/remarkjs/remark/commit/f6bd64e6)
Refactor `tsconfig`s for perf and strictness
- [`bb4c814`](https://github.com/remarkjs/remark/commit/bb4c8143) Add
improved docs on what this project is
by [@&#8203;BeLi4L](https://github.com/BeLi4L) in
[https://github.com/remarkjs/remark/pull/1147](https://github.com/remarkjs/remark/pull/1147)
- [`bec44aa`](https://github.com/remarkjs/remark/commit/bec44aa0)
Update `tsconfig.json` to use node16 module resolution
by [@&#8203;ChristianMurphy](https://github.com/ChristianMurphy) in
[https://github.com/remarkjs/remark/pull/1106](https://github.com/remarkjs/remark/pull/1106)
- [`f07f413`](https://github.com/remarkjs/remark/commit/f07f413f) Add
`ignore-scripts` to `.npmrc`
by [@&#8203;ChristianMurphy](https://github.com/ChristianMurphy) in
[https://github.com/remarkjs/remark/pull/1103](https://github.com/remarkjs/remark/pull/1103)
- [`134ece2`](https://github.com/remarkjs/remark/commit/134ece2b)
Update Actions
by [@&#8203;ChristianMurphy](https://github.com/ChristianMurphy) in
[https://github.com/remarkjs/remark/pull/1070](https://github.com/remarkjs/remark/pull/1070)
- [`974f893`](https://github.com/remarkjs/remark/commit/974f8936) Fix
internal types for TS 4.9

##### Plugins

- [`1e488d0`](https://github.com/remarkjs/remark/commit/1e488d0b) Add
`remark-ins` to list of plugins
by [@&#8203;talatkuyuk](https://github.com/talatkuyuk) in
[https://github.com/remarkjs/remark/pull/1129](https://github.com/remarkjs/remark/pull/1129)
- [`e456dc5`](https://github.com/remarkjs/remark/commit/e456dc5b) Add
`remark-flexible-markers` to list of plugins
by [@&#8203;talatkuyuk](https://github.com/talatkuyuk) in
[https://github.com/remarkjs/remark/pull/1126](https://github.com/remarkjs/remark/pull/1126)
- [`42114fc`](https://github.com/remarkjs/remark/commit/42114fc6) Add
`remark-flexible-paragraphs` to list of plugins
by [@&#8203;talatkuyuk](https://github.com/talatkuyuk) in
[https://github.com/remarkjs/remark/pull/1120](https://github.com/remarkjs/remark/pull/1120)
- [`6aa638a`](https://github.com/remarkjs/remark/commit/6aa638ab) Add
`remark-flexible-containers` to list of plugins
by [@&#8203;talatkuyuk](https://github.com/talatkuyuk) in
[https://github.com/remarkjs/remark/pull/1112](https://github.com/remarkjs/remark/pull/1112)
- [`20e7543`](https://github.com/remarkjs/remark/commit/20e75435) Add
`remark-flexible-code-titles` to list of plugins
by [@&#8203;talatkuyuk](https://github.com/talatkuyuk) in
[https://github.com/remarkjs/remark/pull/1108](https://github.com/remarkjs/remark/pull/1108)
- [`32d6948`](https://github.com/remarkjs/remark/commit/32d69488) Add
`remark-cloudinary-docusaurus` to list of plugins
by [@&#8203;johnnyreilly](https://github.com/johnnyreilly) in
[https://github.com/remarkjs/remark/pull/1090](https://github.com/remarkjs/remark/pull/1090)
- [`28aa8b9`](https://github.com/remarkjs/remark/commit/28aa8b9a)
update tests for changes in `mdast-util-to-markdown`
- [`9af1a87`](https://github.com/remarkjs/remark/commit/9af1a876) Add
`remark-code-title` to list of plugins
by [@&#8203;kevinzunigacuellar](https://github.com/kevinzunigacuellar)
in
[https://github.com/remarkjs/remark/pull/1076](https://github.com/remarkjs/remark/pull/1076)
- [`0d1eb09`](https://github.com/remarkjs/remark/commit/0d1eb09a) Add
7 plugins to list of plugins
by [@&#8203;Xunnamius](https://github.com/Xunnamius) in
[https://github.com/remarkjs/remark/pull/1064](https://github.com/remarkjs/remark/pull/1064)
- [`c7e8171`](https://github.com/remarkjs/remark/commit/c7e81713)
Remove deprecated `remark-jargon`
by [@&#8203;LunaticMuch](https://github.com/LunaticMuch) in
[https://github.com/remarkjs/remark/pull/1059](https://github.com/remarkjs/remark/pull/1059)

**Full Changelog**:
remarkjs/remark@14.0.2...14.0.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/tailscale-dev/tailscale-dev).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS44Ny4xIiwidXBkYXRlZEluVmVyIjoiMzUuODcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

3 participants