fix: 修复 tabBar icon 使用网络图片编译报错的问题

fix #697
remaxjs · Mar 13, 2020 · baaf172 · baaf172
1 parent cdabbdf
commit baaf172
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 9 deletions.
diff --git a/packages/remax-alipay/src/node/index.ts b/packages/remax-alipay/src/node/index.ts
@@ -70,7 +70,7 @@ const plugin: RemaxNodePluginConstructor = () => {
           (images: string[], tab: any) => [...images, tab.icon, tab.activeIcon],
           []
         )
-        .filter((image: string) => !!image)
+        .filter((image: any) => !!image && !/^http(s?):\/\//.test(image))
         .reduce<string[]>(
           (paths, image) => [...paths, path.join(ROOT_DIR, image)],
           []

diff --git a/packages/remax-cli/src/__tests__/fixtures/alipay/expected/app.json b/packages/remax-cli/src/__tests__/fixtures/alipay/expected/app.json
@@ -29,7 +29,7 @@
       {
         "pagePath": "packageA/pages/index",
         "name": "其他",
-        "icon": "./assets/images/cat.png",
+        "icon": "https://img.com/assets/images/cat.png",
         "activeIcon": "./assets/images/dog.png"
       }
     ]

diff --git a/packages/remax-cli/src/__tests__/fixtures/alipay/src/app.config.js b/packages/remax-cli/src/__tests__/fixtures/alipay/src/app.config.js
@@ -24,7 +24,7 @@ module.exports = {
       {
         pagePath: 'packageA/pages/index',
         name: '其他',
-        icon: './assets/images/cat.png',
+        icon: 'https://img.com/assets/images/cat.png',
         activeIcon: './assets/images/dog.png',
       },
     ],

diff --git a/packages/remax-cli/src/__tests__/fixtures/toutiao/expected/app.json b/packages/remax-cli/src/__tests__/fixtures/toutiao/expected/app.json
@@ -29,7 +29,7 @@
       {
         "pagePath": "packageA/pages/index",
         "text": "其他",
-        "iconPath": "./assets/images/cat.png",
+        "iconPath": "https://img.com/assets/images/cat.png",
         "selectedIconPath": "./assets/images/dog.png"
       }
     ]

diff --git a/packages/remax-cli/src/__tests__/fixtures/toutiao/src/app.config.js b/packages/remax-cli/src/__tests__/fixtures/toutiao/src/app.config.js
@@ -25,7 +25,7 @@ module.exports = {
       {
         pagePath: 'packageA/pages/index',
         text: '其他',
-        iconPath: './assets/images/cat.png',
+        iconPath: 'https://img.com/assets/images/cat.png',
         selectedIconPath: './assets/images/dog.png',
       },
     ],

diff --git a/packages/remax-cli/src/__tests__/fixtures/wechat/expected/app.json b/packages/remax-cli/src/__tests__/fixtures/wechat/expected/app.json
@@ -29,7 +29,7 @@
       {
         "pagePath": "packageA/pages/index",
         "text": "其他",
-        "iconPath": "./assets/images/cat.png",
+        "iconPath": "https://img.com/assets/images/cat.png",
         "selectedIconPath": "./assets/images/dog.png"
       }
     ]

diff --git a/packages/remax-cli/src/__tests__/fixtures/wechat/src/app.config.js b/packages/remax-cli/src/__tests__/fixtures/wechat/src/app.config.js
@@ -25,7 +25,7 @@ module.exports = {
       {
         pagePath: 'packageA/pages/index',
         text: '其他',
-        iconPath: './assets/images/cat.png',
+        iconPath: 'https://img.com/assets/images/cat.png',
         selectedIconPath: './assets/images/dog.png',
       },
     ],

diff --git a/packages/remax-toutiao/src/node/index.ts b/packages/remax-toutiao/src/node/index.ts
@@ -70,7 +70,7 @@ const plugin: RemaxNodePluginConstructor = () => {
           ],
           []
         )
-        .filter((image: any) => !!image)
+        .filter((image: any) => !!image && !/^http(s?):\/\//.test(image))
         .reduce<string[]>(
           (paths, image) => [...paths, path.join(ROOT_DIR, image)],
           []

diff --git a/packages/remax-wechat/src/node/index.ts b/packages/remax-wechat/src/node/index.ts
@@ -76,7 +76,7 @@ const plugin: RemaxNodePluginConstructor = () => {
           ],
           []
         )
-        .filter((image: any) => !!image)
+        .filter((image: any) => !!image && !/^http(s?):\/\//.test(image))
         .reduce<string[]>(
           (paths, image) => [...paths, path.join(ROOT_DIR, image)],
           []