支持注册基础组件 #324

Darmody · 2019-11-08T04:50:07Z

No description provided.

vercel · 2019-11-08T04:50:11Z

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/yesmeck/remax/377cptjah
🌍 Preview: https://remax-git-feat-keep-updating.yesmeck.now.sh

docs/guide/component.md

codecov · 2019-11-08T05:26:57Z

Codecov Report

Merging #324 into master will increase coverage by 0.86%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   92.42%   93.29%   +0.86%     
==========================================
  Files         183      225      +42     
  Lines        2641     2817     +176     
  Branches      328      335       +7     
==========================================
+ Hits         2441     2628     +187     
+ Misses        199      188      -11     
  Partials        1        1

Impacted Files	Coverage Δ
packages/remax/src/propsAlias.ts	`100% <ø> (ø)`	⬆️
packages/remax-cli/src/build/adapters/index.ts	`100% <ø> (ø)`	⬆️
...remax/src/adapters/wechat/components/RadioGroup.ts	`100% <100%> (ø)`	⬆️
...ges/remax/src/adapters/wechat/components/Slider.ts	`100% <100%> (ø)`	⬆️
packages/remax/src/createHostComponent.ts	`100% <100%> (ø)`
...src/adapters/alipay/components/PickerViewColumn.ts	`100% <100%> (ø)`	⬆️
...ges/remax/src/adapters/alipay/components/Canvas.ts	`100% <100%> (ø)`	⬆️
...ax/src/adapters/wechat/components/CheckboxGroup.ts	`100% <100%> (ø)`	⬆️
...s/remax/src/adapters/wechat/components/OpenData.ts	`100% <100%> (ø)`	⬆️
...kages/remax/src/adapters/wechat/components/Text.ts	`100% <100%> (ø)`	⬆️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8857729...edae15e. Read the comment docs.

docs/guide/api.md

packages/remax/src/createRemaxComponent.ts

docs/guide/component.md

packages/remax-cli/src/build/plugins/components.ts

docs/guide/component.md

yesmeck · 2019-11-12T12:11:38Z

API 改成:

import { createNativeComponent } from 'remax';

const Video = createNativeComponent('video');

createNativeComponent 内部给标签加上 native- 前缀。

通过这种方式创建的组件不支持设置动态属性

Darmody · 2019-11-12T14:56:42Z

API 改成:
import { createNativeComponent } from 'remax';

const Video = createNativeComponent('video');
createNativeComponent 内部给标签加上 native- 前缀。

通过这种方式创建的组件不支持设置动态属性

这样还是同一个问题，cli不知道这个组件是用户创建的。
本质上就是我们要在编译阶段知道用户创建哪些组件，并有哪些属性

yesmeck · 2019-11-13T03:10:44Z

这样吧，定义一个基础组件：

// Video.js
import { createNativeComponent } from 'remax';

export const nativeComponent = true;

export const props = ['src', 'autoPlay'];

const Video = createNativeComponent('video');

export default Video;

使用：

import Video from './Video.js';

export default () => <Video src="xx" />

然后 cli 在构建的时候，跟处理自定义组件的方式类似，在构建时也去 require Video.js，看里面的 nativeComponent 标识和 props。

Darmody · 2019-11-13T03:52:47Z

*.native.js 定义为与原生相关的文件。

export const type = 'component'

识别为原生组件。

这样以后也可以扩展，定义原生 API 等等。

这样如何

yesmeck · 2019-11-13T03:54:18Z

API 没这个需求吧，组件这么搞主要是为了照顾构建时

yesmeck · 2019-11-13T03:55:19Z

.native.js

用这种后缀 ts 会有问题。

Darmody · 2019-11-13T03:56:06Z

API 没这个需求吧，组件这么搞主要是为了照顾构建时

API不这么弄也可以。主要是 native.js。这样可以很方便得识别出来。不然通过 babel 识别很麻烦。

Darmody · 2019-11-13T03:57:13Z

.native.js

用这种后缀 ts 会有问题。

native.js native.ts 都处理呗

yesmeck · 2019-11-13T03:57:19Z

不需要 babel 解析，直接去 require 就可以的。Video.js 直接会同时在运行时和构建时执行。

Darmody · 2019-11-13T03:57:52Z

不需要 babel 解析，直接去 require 就可以的。Video.js 直接会同时在运行时和构建时执行。

怎么判断 Video.js 是原生组件，需要 require 的？

Darmody · 2019-11-13T04:06:42Z

不然还是解析 createNativeComponent 表达式。

createNativeComponent('custom-component', ['foo', 'bar'])；

要求参数都必须直接声明，不能用变量。

packages/remax/macro/createHostComponent.js

packages/remax/macro/createHostComponent.d.ts

由于type定义很多本身必填的 option 其实也是不需要的，所以不如去掉 optionalPromisify，给 promisify 的 option 加个默认值

Darmody · 2019-11-20T11:37:04Z

这个 codesandbox ci 不发包应该是过不了了

docs/guide/component.md

yesmeck · 2019-11-20T12:43:14Z

remax.macro 先单独发一个吧

yesmeck · 2019-11-20T12:43:30Z

发个 0.0.1，不然没法测试

Darmody · 2019-11-20T12:44:15Z

remax.macro 先单独发一个吧

这个已经发了，是 remax 还没发

yesmeck · 2019-11-20T12:47:16Z

那 codesandbox 应该能构建出来啊

Darmody · 2019-11-20T12:48:25Z

那 codesandbox 应该能构建出来啊

那你进去看看为什么 codesandbox 不行

Darmody · 2019-11-20T12:55:47Z

那 codesandbox 应该能构建出来啊

搞定了 😈

packages/remax/macro.js

yesmeck · 2019-11-20T16:10:12Z

packages/remax/macro.js

@@ -0,0 +1,14 @@
+function exportWrapper(module) {


这个文件没在 npm 包里

codesandbox 吗？我下下来有啊

引入 remax.macro 注册 host 组件 resolve #293

Darmody requested review from yesmeck and Pochodaydayup November 8, 2019 04:50

Darmody commented Nov 8, 2019

View reviewed changes

docs/guide/component.md Show resolved Hide resolved

Darmody force-pushed the feat/keep-updating branch from 9d008d2 to c9a3331 Compare November 8, 2019 05:22

vercel bot deployed to staging November 8, 2019 05:22 View deployment

Darmody force-pushed the feat/keep-updating branch from c9a3331 to 25352fd Compare November 8, 2019 12:28

vercel bot deployed to staging November 8, 2019 12:28 View deployment

Darmody closed this Nov 12, 2019

yesmeck reopened this Nov 12, 2019

yesmeck changed the title ~~Feat/keep updating~~ 支持注册组件 Nov 12, 2019

yesmeck reviewed Nov 12, 2019

View reviewed changes

docs/guide/api.md Outdated Show resolved Hide resolved

Darmody commented Nov 12, 2019

View reviewed changes

packages/remax/src/createRemaxComponent.ts Outdated Show resolved Hide resolved

Darmody force-pushed the feat/keep-updating branch from 25352fd to 07a29ff Compare November 12, 2019 09:37

vercel bot deployed to staging November 12, 2019 09:37 View deployment

yesmeck reviewed Nov 12, 2019

View reviewed changes

docs/guide/component.md Outdated Show resolved Hide resolved

Darmody commented Nov 12, 2019

View reviewed changes

packages/remax-cli/src/build/plugins/components.ts Outdated Show resolved Hide resolved

yesmeck reviewed Nov 12, 2019

View reviewed changes

docs/guide/component.md Outdated Show resolved Hide resolved

Darmody force-pushed the feat/keep-updating branch 2 times, most recently from 113be4c to 72d5c1c Compare November 19, 2019 06:16

yesmeck reviewed Nov 19, 2019

View reviewed changes

packages/remax/macro/createHostComponent.js Outdated Show resolved Hide resolved

yesmeck reviewed Nov 19, 2019

View reviewed changes

packages/remax/macro/createHostComponent.d.ts Outdated Show resolved Hide resolved

Darmody force-pushed the feat/keep-updating branch from 72d5c1c to 01eacb7 Compare November 20, 2019 10:53

refactor: 去除 optionalPromisify

d7ce58c

由于type定义很多本身必填的 option 其实也是不需要的，所以不如去掉 optionalPromisify，给 promisify 的 option 加个默认值

Darmody force-pushed the feat/keep-updating branch 2 times, most recently from 16b7af0 to 0e5bf7d Compare November 20, 2019 11:17

yesmeck reviewed Nov 20, 2019

View reviewed changes

docs/guide/component.md Outdated Show resolved Hide resolved

yesmeck reviewed Nov 20, 2019

View reviewed changes

docs/guide/component.md Outdated Show resolved Hide resolved

Darmody force-pushed the feat/keep-updating branch 2 times, most recently from 1b56cf3 to 6a7c57d Compare November 20, 2019 12:54

Darmody force-pushed the feat/keep-updating branch 3 times, most recently from b5a5e1c to f1a1e33 Compare November 20, 2019 13:34

yesmeck reviewed Nov 20, 2019

View reviewed changes

packages/remax/macro.js Outdated Show resolved Hide resolved

yesmeck reviewed Nov 20, 2019

View reviewed changes

Darmody force-pushed the feat/keep-updating branch 2 times, most recently from 03c51ad to 14dbc57 Compare November 21, 2019 00:16

feat: 支持开发者注册 host 组件

edae15e

引入 remax.macro 注册 host 组件 resolve #293

Darmody force-pushed the feat/keep-updating branch from 14dbc57 to edae15e Compare November 21, 2019 01:54

yesmeck merged commit 4ba9c45 into master Nov 21, 2019

yesmeck deleted the feat/keep-updating branch November 21, 2019 06:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

支持注册基础组件 #324

支持注册基础组件 #324

Darmody commented Nov 8, 2019 •

edited by yesmeck

Loading

vercel bot commented Nov 8, 2019 •

edited

Loading

codecov bot commented Nov 8, 2019 •

edited

Loading

yesmeck commented Nov 12, 2019

Darmody commented Nov 12, 2019

yesmeck commented Nov 13, 2019 •

edited

Loading

Darmody commented Nov 13, 2019

yesmeck commented Nov 13, 2019

yesmeck commented Nov 13, 2019

Darmody commented Nov 13, 2019

Darmody commented Nov 13, 2019

yesmeck commented Nov 13, 2019

Darmody commented Nov 13, 2019

Darmody commented Nov 13, 2019 •

edited

Loading

Darmody commented Nov 20, 2019

yesmeck commented Nov 20, 2019

yesmeck commented Nov 20, 2019

Darmody commented Nov 20, 2019

yesmeck commented Nov 20, 2019

Darmody commented Nov 20, 2019

Darmody commented Nov 20, 2019 •

edited

Loading

yesmeck Nov 20, 2019

Darmody Nov 21, 2019

支持注册基础组件 #324

支持注册基础组件 #324

Conversation

Darmody commented Nov 8, 2019 • edited by yesmeck Loading

vercel bot commented Nov 8, 2019 • edited Loading

codecov bot commented Nov 8, 2019 • edited Loading

Codecov Report

yesmeck commented Nov 12, 2019

Darmody commented Nov 12, 2019

yesmeck commented Nov 13, 2019 • edited Loading

Darmody commented Nov 13, 2019

yesmeck commented Nov 13, 2019

yesmeck commented Nov 13, 2019

Darmody commented Nov 13, 2019

Darmody commented Nov 13, 2019

yesmeck commented Nov 13, 2019

Darmody commented Nov 13, 2019

Darmody commented Nov 13, 2019 • edited Loading

Darmody commented Nov 20, 2019

yesmeck commented Nov 20, 2019

yesmeck commented Nov 20, 2019

Darmody commented Nov 20, 2019

yesmeck commented Nov 20, 2019

Darmody commented Nov 20, 2019

Darmody commented Nov 20, 2019 • edited Loading

yesmeck Nov 20, 2019

Choose a reason for hiding this comment

Darmody Nov 21, 2019

Choose a reason for hiding this comment

Darmody commented Nov 8, 2019 •

edited by yesmeck

Loading

vercel bot commented Nov 8, 2019 •

edited

Loading

codecov bot commented Nov 8, 2019 •

edited

Loading

yesmeck commented Nov 13, 2019 •

edited

Loading

Darmody commented Nov 13, 2019 •

edited

Loading

Darmody commented Nov 20, 2019 •

edited

Loading