Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix: 去除没有使用 ref 时原生自定义组件抛出无用的警告 #486

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Dec 15, 2019

fix #478

@Darmody Darmody requested a review from yesmeck December 15, 2019 02:54
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 15, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d270d1e:

Sandbox Source
nostalgic-rgb-svlfh Configuration

@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #486 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #486      +/-   ##
=========================================
+ Coverage   97.27%   97.3%   +0.03%     
=========================================
  Files         296     296              
  Lines        3231    3230       -1     
  Branches      346     345       -1     
=========================================
  Hits         3143    3143              
  Misses         86      86              
+ Partials        2       1       -1
Impacted Files Coverage Δ
packages/remax/src/createNativeComponent.ts 90% <100%> (+8.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ceaa23...bbf40b6. Read the comment docs.

@Darmody Darmody merged commit 89ccaa1 into master Dec 15, 2019
@Darmody Darmody deleted the fix/ref-warning branch December 15, 2019 06:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createNativeComponent 现在的实现容易因为没有 ref 报 warning
1 participant