Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-260 add terraform module for creating static website #38

Merged
merged 11 commits into from
May 16, 2024
Merged

CORE-260 add terraform module for creating static website #38

merged 11 commits into from
May 16, 2024

Conversation

tundeaoni
Copy link
Contributor

@tundeaoni tundeaoni commented Apr 12, 2024 •
edited by remerge-hal

@tundeaoni tundeaoni requested a review from a team as a code owner April 12, 2024 13:17
@remerge-hal
Copy link

This comment ensures that the correct Slack channel is notified after the team/project label CORE has been added to this pull request.

See this comment for details.

hollow
hollow reviewed Apr 12, 2024
View reviewed changes
google/static-website/main.tf Outdated Show resolved Hide resolved
google/static-website/main.tf Show resolved Hide resolved
@tundeaoni tundeaoni requested a review from hollow April 12, 2024 13:31
@tundeaoni
Copy link
Contributor Author

tundeaoni commented Apr 12, 2024 •
edited

@hollow I have addressed your comments

@tundeaoni tundeaoni force-pushed the CORE-260-create-deployment-workflow-for-static-web-applications branch from bcfcba8 to e293978 Compare May 3, 2024 13:14
@tundeaoni tundeaoni force-pushed the CORE-260-create-deployment-workflow-for-static-web-applications branch from 3dd577d to 4a7dbe3 Compare May 3, 2024 13:16
alexmorten
alexmorten previously requested changes May 6, 2024
View reviewed changes
Copy link

@alexmorten alexmorten left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Wrong PR

@alexmorten alexmorten dismissed their stale review May 6, 2024 15:10

I did this in a wrong tab

@tundeaoni tundeaoni merged commit 090bb68 into main May 16, 2024
1 check passed
@tundeaoni tundeaoni deleted the CORE-260-create-deployment-workflow-for-static-web-applications branch May 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollow hollow hollow approved these changes

@alexmorten alexmorten alexmorten left review comments

Assignees
No one assigned
Labels
CORE
Milestone
No milestone
4 participants
@tundeaoni @remerge-hal @hollow @alexmorten