Add flag for stack name template #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobologic
approved these changes
Jul 28, 2017
cmd/empire/main.go
Outdated
| @@ -376,6 +378,12 @@ var EmpireFlags = []cli.Flag{ | |||
| EnvVar: "EMPIRE_ROUTE53_INTERNAL_ZONE_ID", | |||
| }, | |||
| cli.StringFlag{ | |||
| Name: FlagCloudFormationStackNameTemplate, | |||
| Value: "", | |||
| Usage: "If provided, this should be a Go text/template that will be used to generate a CloudFormation stack name for an application.", | |||
There was a problem hiding this comment.
maybe a comment about what happens if not specified in the usage?
ejholmes
force-pushed
the
stack-name-template
branch
2 times, most recently
from
0c63b08
to
cc604c3
Compare
ejholmes
force-pushed
the
stack-name-template
branch
from
cc604c3
to
52cc59f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
--environmentflag was used to generate a template for determining the CloudFormation stack name for an application. This can be a little constraining and overloaded the responsibilities of--environment.With this change, you can now directly specify a stack name template like this:
EMPIRE_CLOUDFORMATION_STACK_NAME_TEMPLATE="my-custom-prefix-{{.Name}}"Empire will still fallback to including
--environmentin the prefix if--cloudformation.stack-name-templateisn't provided.