Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Godeps in this, so you probably want to ignore the first commit.
This is a redesign of the authentication and authorization layer to fix some bugs and improve the existing behavior, as well as open it up for the addition of more granular authorization in the (near?) future.
But, primarily, this does the following:
however, the implementation should probably cache in memory for some reasonable amount of time for perf reasonsthis now gets cached for 30 minutes in memory, if the authorization check is positive).server/authorization/github/client_test.go
have been fixed.Configuration is also logged on boot now:
TODO