Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weired special case in q_emiTeDetail #41

Open
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Jan 20, 2020 · 1 comment
Open

Weired special case in q_emiTeDetail #41

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Jan 20, 2020 · 1 comment
Assignees
Labels
code cleaning Code that could/should be cleaned up question Further information is requested

Comments

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented Jan 20, 2020

remind/core/equations.gms

Lines 478 to 502 in 08e58ef

***-----------------------------------------------------------------------------
*' Emissions result from primary to secondary energy transformation,
*' from secondary to final energy transformation (some air pollutants), or
*' transformations within the chain of CCS steps (Leakage).
***-----------------------------------------------------------------------------
q_emiTeDetail(t,regi,enty,enty2,te,enty3)$( emi2te(enty,enty2,te,enty3)
OR ( pe2se(enty,enty2,te)
AND sameas(enty3,"cco2")) ) ..
vm_emiTeDetail(t,regi,enty,enty2,te,enty3)
=e=
sum(emi2te(enty,enty2,te,enty3),
sum(pe2se(enty,enty2,te),
pm_emifac(t,regi,enty,enty2,te,enty3)
* vm_demPE(t,regi,enty,enty2,te)
)
+ sum(se2fe(enty,enty2,te),
pm_emifac(t,regi,enty,enty2,te,enty3)
* vm_prodFE(t,regi,enty,enty2,te)
)
+ sum((ccs2Leak(enty,enty2,te,enty3),teCCS2rlf(te,rlf)),
pm_emifac(t,regi,enty,enty2,te,enty3)
* vm_co2CCS(t,regi,enty,enty2,te,rlf)
)
)
;

I don't see any point in (and am confused by) the OR (pe2se(enty,enty2,te) AND sameas(enty3,"cco2")) part. This would come into play for combinations of (pety,sety,te,"cco2") that are not present in emi2te yet have non-zero data in pm_emifac. This might happen if new data is included in ./core/input/generisdata_emi.put, but is not the case at the moment.
However, these entries would be excluded from the equation in any case, since it sums over emi2te, of which they are not a part. (Incidentally, this sum does nothing productive besides excluding the non-existent cases that were manually included.)
Do you have any idea what was the reasoning behind this? I will delete it, unless there's some foreseeable edge-case where this is necessary.

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q added question Further information is requested code cleaning Code that could/should be cleaned up labels Jan 20, 2020
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

Bump @strefler.

dklein-pik pushed a commit to dklein-pik/remind that referenced this issue Dec 2, 2020
Renato-Rodrigues added a commit that referenced this issue Apr 22, 2022
…enhgab/edge-t-GDP-patch

more verbose yet restricted bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleaning Code that could/should be cleaned up question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants