rename and improve description of weathering rates #1929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
p33_co2_rem_rate and s33_co2_rem_rate currently have the same description, albeit meaning different things.
To make it more accessible and have different names, I suggest to rename the latter to s33_co2_rem_fraction, as it actually provides the (theoretical) fraction weathering each year. Alternatively, we could call it p33_co2_rem_exponent?
The PR also changes the description in the declarations.
Happy to further improve the description or names based on your suggestions.
If you agree to the renaming, I will also need to adjust it in remind2.
Type of change
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly@strefler @amerfort
for reference @VerenaHof @robertsalzwedel