-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename all_enty occurrences which only depend on emiTe #500
Open
spahrm
wants to merge
45
commits into
remindmodel:develop
Choose a base branch
from
spahrm:feature/oneByOne_all_enty
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly depending on emiTe. No changes in testOneRegi
…. No changes in testOneRegi
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…demand, o_emissions_energy_supply_gross, o_emissions_energy_supply_gross_carrier s all_enty to emiTe. No changes in testOneRegi
…No changes in testOneRegi
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of the refactoring of the
all_enty
from Remind. Replacing this set step by step improves readability and makes it more clear which part of the set is actually used in equations, parameters and variables.In the first step a report was generated which contains all variables,parameters and equations, depending on
all_enty
, but actually only in a subset form from the setemiTe
. This report can be found here:emiTeReport.csv
Afterwards all occurrences of these variables where located in the remind folder and replaced with
emiTe
instead ofall_enty
. After each replacement atestOneRegi
run was performed to check if simulation results alter. After all possible variables were renamed, SSP and policy runs where executed to check the simulation results even more carefully.There are changes between the
develop
and theemiTe
runs, please review them carefully.