fix(Dockerfile): update npm commands #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
changed the title
MichaelDeBoey
requested changes
May 6, 2023
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
MichaelDeBoey
approved these changes
May 8, 2023
There was a problem hiding this comment.
Tagging @rubys as he might be interested in also implementing this in dockerfile-node
rubys
added a commit
to fly-apps/dockerfile-node
that referenced
this pull request
May 8, 2023
rubys
added a commit
to fly-apps/dockerfile-node
that referenced
this pull request
May 8, 2023
|
Just a note: some npm packages require scripts to install. The default for npm, yarn, and pnpm is to run those scripts. That may create security issues, so each provide an option to disable running those scripts. |
|
@rubys That's why I let @kwigley remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes npm warnings during docker build