fix: don't add FLY_REGION prefix when using recent flyctl version
#187
Conversation
New versions of `flyctl`, when running `fly postgres attach`, use [flycast](https://fly.io/docs/reference/private-networking/#flycast-private-load-balancing) URLs to connect to the DB. This provides the same geo-aware load balancing that the stack already achieves today by prefixing the hostname with the region. Flycast doesn't support region prefixes. This has been causing failures for new apps. For example: Old: `postgres://top2.nearest.of.my-postgres.internal` New: `postgres://my-postgres.flycast` The old format supports a region prefix, but the new one does not. Fixes #182
|
@MichaelDeBoey can you take a look at this PR when you get some time? |
MichaelDeBoey
changed the title
FLY_REGION prefix when using recent flyctl version
There was a problem hiding this comment.
Thanks for taking the time to fix this @benwaffle! 🙏
I do have 1 concern though: I would either remove the message in the README and just assume people are using the latest version of flyctl (just like we do with all other changes in our stacks) or I would conditionally add/remove the FLY_REGION prefix to databaseUrl.host
Not sure which one I would prefer though 🤔
Pinging the team to hear what they think about this @brophdawg11 @jacob-ebey @markdalgleish @mcansh
|
What about adding the FLY_REGION prefix only if the host ends with |
|
I'd appreciate it if this were expedited, developers are seeing problems with apps v2 and we are making a push to move people off of apps v1. |
|
@rubys The updated code looked good to me. Merged! :) |
New versions of
flyctl, when runningfly postgres attach, use flycast URLs to connect to the DB. This provides the same geo-aware load balancing that the stack already achieves today by prefixing the hostname with the region. Flycast doesn't support region prefixes. This has been causing failures for new apps.For example:
Old:
postgres://top2.nearest.of.my-postgres.internalNew:
postgres://my-postgres.flycastThe old format supports a region prefix, but the new one does not.
Closes #88
Closes #101
Closes #182