allow histories to cancel location updates #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you include the update to |
|
Done! |
|
LGTM. The only potential concern I have is using I'll let someone else merge this as well :D |
| @@ -114,8 +114,9 @@ function createHistory(options={}) { | |||
| return // Transition was interrupted. | |||
|
|
|||
| if (ok) { | |||
| finishTransition(nextLocation) | |||
| updateLocation(nextLocation) | |||
| if(finishTransition(nextLocation) !== false) { | |||
There was a problem hiding this comment.
Nit: missing space after if
|
Thanks, @jlongster! Great call. And thanks for the review, @taion and @gaearon. I'll manually rebase and merge. |
|
Merged in 0148f1f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is spawned from #100. Right now if a browser doesn't support
pushState(or the user is forcing full refreshes), the router still immediately calls listeners, meaning react-router still tries to immediately render the new location within the same page, even though a full reload has been triggered. This causes glitches when navigating: the page changes (most likely to an invalid state) and then a second later the whole thing reloads.This allows
finishTransitionincreateBrowserHistoryto returnfalsewhen reloading the whole page to cancel location updates, so nothing happens.