Skip to content

Commit

Permalink
no react-router re-exports from node
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanflorence committed Jun 21, 2024
1 parent 647338c commit 4cd089e
Show file tree
Hide file tree
Showing 12 changed files with 31 additions and 74 deletions.
10 changes: 10 additions & 0 deletions .changeset/nine-ravens-work.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"react-router-dom": major
"@react-router/express": major
"react-router": major
"@react-router/serve": major
"@react-router/node": major
"@react-router/dev": major
---

node package no longer re-exports from react-router
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { MetaFunction } from "@react-router/node";
import type { MetaFunction } from "react-router";

export const meta: MetaFunction = () => {
return [
Expand Down
2 changes: 1 addition & 1 deletion packages/remix-dev/__tests__/fixtures/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"typecheck": "tsc"
},
"dependencies": {
"react-router": "*",
"@react-router/node": "*",
"@react-router/react": "*",
"@react-router/serve": "*",
"isbot": "^4.1.0",
"react": "^18.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/remix-dev/config/defaults/entry.server.node.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { PassThrough } from "node:stream";

import type { AppLoadContext, EntryContext } from "@react-router/node";
import type { AppLoadContext, EntryContext } from "react-router";
import { createReadableStreamFromReadable } from "@react-router/node";
import { ServerRouter } from "react-router";
import * as isbotModule from "isbot";
Expand Down
4 changes: 1 addition & 3 deletions packages/remix-dev/vite/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1658,9 +1658,7 @@ async function getPrerenderBuildAndHandler(
reactRouterConfig.serverBuildFile
);
let build = await import(url.pathToFileURL(serverBuildPath).toString());
let { createRequestHandler: createHandler } = await import(
"@react-router/node"
);
let { createRequestHandler: createHandler } = await import("react-router");
return {
build,
handler: createHandler(build, viteConfig.mode),
Expand Down
10 changes: 4 additions & 6 deletions packages/remix-express/__tests__/server-test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { Readable } from "node:stream";
import {
createReadableStreamFromReadable,
createRequestHandler as createRemixRequestHandler,
} from "@react-router/node";
import { createRequestHandler as createRemixRequestHandler } from "react-router";
import { createReadableStreamFromReadable } from "@react-router/node";
import express from "express";
import { createRequest, createResponse } from "node-mocks-http";
import supertest from "supertest";
Expand All @@ -15,8 +13,8 @@ import {

// We don't want to test that the remix server works here (that's what the
// playwright tests do), we just want to test the express adapter
jest.mock("@react-router/node", () => {
let original = jest.requireActual("@react-router/node");
jest.mock("react-router", () => {
let original = jest.requireActual("react-router");
return {
...original,
createRequestHandler: jest.fn(),
Expand Down
1 change: 1 addition & 0 deletions packages/remix-express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
},
"peerDependencies": {
"express": "^4.17.1",
"react-router": "workspace:*",
"typescript": "^5.1.0"
},
"peerDependenciesMeta": {
Expand Down
4 changes: 2 additions & 2 deletions packages/remix-express/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
/// <reference lib="DOM.Iterable" />

import type * as express from "express";
import type { AppLoadContext, ServerBuild } from "@react-router/node";
import type { AppLoadContext, ServerBuild } from "react-router";
import { createRequestHandler as createRemixRequestHandler } from "react-router";
import {
createRequestHandler as createRemixRequestHandler,
createReadableStreamFromReadable,
writeReadableStreamToWritable,
} from "@react-router/node";
Expand Down
59 changes: 0 additions & 59 deletions packages/remix-node/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,62 +20,3 @@ export {
writeAsyncIterableToWritable,
writeReadableStreamToWritable,
} from "./stream";

export {
createRequestHandler,
createSession,
defer,
isCookie,
isSession,
json,
MaxPartSizeExceededError,
redirect,
redirectDocument,
unstable_composeUploadHandlers,
unstable_createMemoryUploadHandler,
unstable_parseMultipartFormData,
} from "react-router";

export type {
ActionFunction,
ActionFunctionArgs,
AppLoadContext,
Cookie,
CookieOptions,
CookieParseOptions,
CookieSerializeOptions,
CookieSignatureOptions,
DataFunctionArgs,
EntryContext,
ErrorResponse,
HandleDataRequestFunction,
HandleDocumentRequestFunction,
HeadersArgs,
HeadersFunction,
HtmlLinkDescriptor,
JsonFunction,
LinkDescriptor,
LinksFunction,
LoaderFunction,
LoaderFunctionArgs,
MemoryUploadHandlerFilterArgs,
MemoryUploadHandlerOptions,
HandleErrorFunction,
PageLinkDescriptor,
RequestHandler,
ServerBuild,
ServerEntryModule,
MetaArgs,
MetaDescriptor,
MetaFunction,
Session,
SessionData,
SessionIdStorageStrategy,
SessionStorage,
SignFunction,
TypedDeferredData,
TypedResponse,
UnsignFunction,
UploadHandler,
UploadHandlerPart,
} from "react-router";
2 changes: 1 addition & 1 deletion packages/remix-serve/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import url from "node:url";
import type { ServerBuild } from "@react-router/node";
import type { ServerBuild } from "react-router";
import { installGlobals } from "@react-router/node";
import { createRequestHandler } from "@react-router/express";
import compression from "compression";
Expand Down
3 changes: 3 additions & 0 deletions packages/remix-serve/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
"morgan": "^1.10.0",
"source-map-support": "^0.5.21"
},
"peerDependencies": {
"react-router": "workspace:*"
},
"devDependencies": {
"@types/compression": "^1.7.0",
"@types/express": "^4.17.9",
Expand Down
6 changes: 6 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4cd089e

Please sign in to comment.