Skip to content

Commit

Permalink
no react-router re-exports from node
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanflorence committed Jun 21, 2024
1 parent 647338c commit 7c6aa33
Show file tree
Hide file tree
Showing 60 changed files with 148 additions and 186 deletions.
10 changes: 10 additions & 0 deletions .changeset/nine-ravens-work.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"react-router-dom": major
"@react-router/express": major
"react-router": major
"@react-router/serve": major
"@react-router/node": major
"@react-router/dev": major
---

node package no longer re-exports from react-router
2 changes: 1 addition & 1 deletion integration/abort-signal-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test.beforeAll(async () => {
fixture = await createFixture({
files: {
"app/routes/_index.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import { useActionData, useLoaderData, Form } from "react-router";
export async function action ({ request }) {
Expand Down
2 changes: 1 addition & 1 deletion integration/action-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ test.describe("actions", () => {
`,

[`app/routes/${THROWS_REDIRECT}.jsx`]: js`
import { redirect } from "@react-router/node";
import { redirect } from "react-router";
import { Form } from "react-router";
export function action() {
Expand Down
2 changes: 1 addition & 1 deletion integration/bug-report-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ test.beforeAll(async () => {
////////////////////////////////////////////////////////////////////////////
files: {
"app/routes/_index.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import { useLoaderData, Link } from "react-router";
export function loader() {
Expand Down
2 changes: 1 addition & 1 deletion integration/catch-boundary-data-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ test.describe("ErrorBoundary (thrown responses)", () => {
fixture = await createFixture({
files: {
"app/root.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import {
Links,
Meta,
Expand Down
2 changes: 1 addition & 1 deletion integration/catch-boundary-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ test.describe("ErrorBoundary (thrown responses)", () => {
fixture = await createFixture({
files: {
"app/root.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import { Links, Meta, Outlet, Scripts, useMatches } from "react-router";
export function loader() {
Expand Down
4 changes: 2 additions & 2 deletions integration/defer-loader-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test.describe("deferred loaders", () => {
`,

"app/routes/redirect.tsx": js`
import { defer } from "@react-router/node";
import { defer } from "react-router";
export function loader() {
return defer({food: "pizza"}, { status: 301, headers: { Location: "/?redirected" } });
}
Expand All @@ -37,7 +37,7 @@ test.describe("deferred loaders", () => {

"app/routes/direct-promise-access.tsx": js`
import * as React from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { useLoaderData, Link, Await } from "react-router";
export function loader() {
return defer({
Expand Down
34 changes: 17 additions & 17 deletions integration/defer-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ test.describe("non-aborted", () => {
}
`,
"app/root.tsx": js`
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Links, Meta, Outlet, Scripts, useLoaderData } from "react-router";
import Counter from "~/components/counter";
import Interactive from "~/components/interactive";
Expand Down Expand Up @@ -116,7 +116,7 @@ test.describe("non-aborted", () => {
`,

"app/routes/_index.tsx": js`
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -148,7 +148,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-noscript-resolved.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -183,7 +183,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-noscript-unresolved.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -222,7 +222,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-script-resolved.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -258,7 +258,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-script-unresolved.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -302,7 +302,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-script-rejected.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -343,7 +343,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-script-unrejected.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -409,7 +409,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-script-rejected-no-error-element.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -453,7 +453,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-script-unrejected-no-error-element.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -501,7 +501,7 @@ test.describe("non-aborted", () => {

"app/routes/deferred-manual-resolve.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -568,7 +568,7 @@ test.describe("non-aborted", () => {
`,

"app/routes/headers.tsx": js`
import { defer } from "@react-router/node";
import { defer } from "react-router";
export function loader() {
return defer({}, { headers: { "x-custom-header": "value from loader" } });
}
Expand Down Expand Up @@ -996,8 +996,8 @@ test.describe("aborted", () => {
files: {
"app/entry.server.tsx": js`
import { PassThrough } from "node:stream";
import type { AppLoadContext, EntryContext } from "@react-router/node";
import { createReadableStreamFromReadable } from "@react-router/node";
import type { AppLoadContext, EntryContext } from "react-router";
import { createReadableStreamFromReadable } from "react-router";
import { ServerRouter } from "react-router";
import { isbot } from "isbot";
import { renderToPipeableStream } from "react-dom/server";
Expand Down Expand Up @@ -1142,7 +1142,7 @@ test.describe("aborted", () => {
}
`,
"app/root.tsx": js`
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Links, Meta, Outlet, Scripts, useLoaderData } from "react-router";
import Counter from "~/components/counter";
import Interactive from "~/components/interactive";
Expand Down Expand Up @@ -1184,7 +1184,7 @@ test.describe("aborted", () => {

"app/routes/deferred-server-aborted.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down Expand Up @@ -1229,7 +1229,7 @@ test.describe("aborted", () => {

"app/routes/deferred-server-aborted-no-error-element.tsx": js`
import { Suspense } from "react";
import { defer } from "@react-router/node";
import { defer } from "react-router";
import { Await, Link, useLoaderData } from "react-router";
import Counter from "~/components/counter";
Expand Down
2 changes: 1 addition & 1 deletion integration/error-boundary-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1291,7 +1291,7 @@ test("Allows back-button out of an error boundary after a hard reload", async ({
`,

"app/routes/boom.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
export function loader() { return boom(); }
export default function() { return <b>my page</b>; }
`,
Expand Down
2 changes: 1 addition & 1 deletion integration/error-sanitization-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ test.describe("Error Sanitization", () => {
"app/entry.server.tsx": js`
import { PassThrough } from "node:stream";
import { createReadableStreamFromReadable } from "@react-router/node";
import { createReadableStreamFromReadable } from "react-router";
import { ServerRouter, isRouteErrorResponse } from "react-router";
import { renderToPipeableStream } from "react-dom/server";
Expand Down
2 changes: 1 addition & 1 deletion integration/fetch-globals-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.beforeAll(async () => {
fixture = await createFixture({
files: {
"app/routes/_index.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import { useLoaderData } from "react-router";
export async function loader() {
const resp = await fetch('https://reqres.in/api/users?page=2');
Expand Down
12 changes: 6 additions & 6 deletions integration/fetcher-layout-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test.beforeAll(async () => {
fixture = await createFixture({
files: {
"app/routes/layout-action.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import { Outlet, useFetcher, useFormAction } from "react-router";
export let action = ({ params }) => json("layout action data");
Expand All @@ -40,7 +40,7 @@ test.beforeAll(async () => {
`,

"app/routes/layout-action._index.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import {
useFetcher,
useFormAction,
Expand Down Expand Up @@ -71,7 +71,7 @@ test.beforeAll(async () => {
`,

"app/routes/layout-action.$param.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import {
useFetcher,
useFormAction,
Expand Down Expand Up @@ -102,7 +102,7 @@ test.beforeAll(async () => {
`,

"app/routes/layout-loader.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import { Outlet, useFetcher, useFormAction } from "react-router";
export let loader = () => json("layout loader data");
Expand All @@ -127,7 +127,7 @@ test.beforeAll(async () => {
`,

"app/routes/layout-loader._index.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import {
useFetcher,
useFormAction,
Expand All @@ -154,7 +154,7 @@ test.beforeAll(async () => {
`,

"app/routes/layout-loader.$param.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import {
useFetcher,
useFormAction,
Expand Down
4 changes: 2 additions & 2 deletions integration/fetcher-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test.describe("useFetcher", () => {
fixture = await createFixture({
files: {
"app/routes/resource-route-action-only.ts": js`
import { json } from "@react-router/node";
import { json } from "react-router";
export function action() {
return new Response("${CHEESESTEAK}");
}
Expand Down Expand Up @@ -149,7 +149,7 @@ test.describe("useFetcher", () => {
`,

"app/routes/fetcher-echo.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import { useFetcher } from "react-router";
export async function action({ request }) {
Expand Down
6 changes: 4 additions & 2 deletions integration/file-uploads-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ test.describe("file-uploads", () => {
import * as url from "node:url";
import {
unstable_composeUploadHandlers as composeUploadHandlers,
unstable_createFileUploadHandler as createFileUploadHandler,
unstable_createMemoryUploadHandler as createMemoryUploadHandler,
} from "react-router";
import {
unstable_createFileUploadHandler as createFileUploadHandler,
} from "@react-router/node";
const __dirname = url.fileURLToPath(new URL(".", import.meta.url));
Expand All @@ -44,7 +46,7 @@ test.describe("file-uploads", () => {
"app/routes/file-upload.tsx": js`
import {
unstable_parseMultipartFormData as parseMultipartFormData,
} from "@react-router/node";
} from "react-router";
import { Form, useActionData } from "react-router";
import { uploadHandler } from "~/fileUploadHandler";
Expand Down
2 changes: 1 addition & 1 deletion integration/form-data-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ test.beforeAll(async () => {
fixture = await createFixture({
files: {
"app/routes/_index.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
export async function action({ request }) {
try {
Expand Down
4 changes: 2 additions & 2 deletions integration/form-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ test.describe("Forms", () => {
`,

"app/routes/stop-propagation.tsx": js`
import { json } from "@react-router/node";
import { json } from "react-router";
import { Form, useActionData } from "react-router";
export async function action({ request }) {
Expand All @@ -321,7 +321,7 @@ test.describe("Forms", () => {

"app/routes/form-method.tsx": js`
import { Form, useActionData, useLoaderData, useSearchParams } from "react-router";
import { json } from "@react-router/node";
import { json } from "react-router";
export function action({ request }) {
return json(request.method)
Expand Down
Loading

0 comments on commit 7c6aa33

Please sign in to comment.