fix(@react-router/dev): prevent argv parsing crash when optionnal arg…

…s are passed to the cli (#12609)
remix-run · Dec 21, 2024 · ae9a92d · ae9a92d
1 parent 329fc0a
commit ae9a92d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/contributors.yml b/contributors.yml
@@ -233,6 +233,7 @@
 - pavsoldatov
 - pcattori
 - petersendidit
+- phildl
 - pierophp
 - printfn
 - promet99

diff --git a/packages/react-router-dev/bin.js b/packages/react-router-dev/bin.js
@@ -5,7 +5,7 @@ let arg = require("arg");
 // default `NODE_ENV` so React loads the proper version in it's CJS entry script.
 // We have to do this before importing `run.ts` since that is what imports
 // `react` (indirectly via `react-router`)
-let args = arg({}, { argv: process.argv.slice(2) });
+let args = arg({}, { argv: process.argv.slice(2), stopAtPositional: true });
 if (args._[0] === "dev") {
   process.env.NODE_ENV = process.env.NODE_ENV ?? "development";
 } else {