Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary router subscribes #10409

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

brophdawg11
Copy link
Contributor

Rebased #10400 onto the release-next branch for inclusion in 6.11 since this fixes an issue in Remix apps on React 17.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: 7eeb1da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

});
}, [router, state]);
let [state, setState] = React.useState(router.state);
React.useLayoutEffect(() => router.subscribe(setState), [router, setState]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to check for identity since router.subscribe won't fire unless it changes (and React will bail out if it's the same anyway - https://reacttraining.com/blog/state-in-react-is-immutable)

@brophdawg11 brophdawg11 merged commit f4a452b into release-next Apr 27, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/router-layout-effect branch April 27, 2023 19:52
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.0-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants