Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export type NavLinkRenderProps #11553

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Conversation

zeromask1337
Copy link
Contributor

Documentation tells us we can use callbacks to utilize various NavLink states

import { NavLink } from "react-router-dom";

<NavLink
  to="/messages"
  className={({ isActive, isPending }) =>
    isPending ? "pending" : isActive ? "active" : ""
  }
>
  Messages
</NavLink>;

But then restricts us by not letting use type annotation for it

import { NavLink } from 'react-router-dom';
import { useCallback } from 'react';

export const Header = () => {
  const navLinkClassName = useCallback(
    ({ isActive, isPending }: NavLinkRenderProps) => // this is impossible right now because type is not exported
      isPending ? 'text-gray-500' : isActive ? 'text-orange-800' : '',
    [],
  );
  return (
    <>
      <header className='h-10 w-full bg-amber-100'>
        <nav className='p-2'>
          <ul className='flex items-center gap-5'>
            <li>
              <NavLink to='/home' className={navLinkClassName}>
                Home
              </NavLink>
            </li>
            <li>
              <NavLink to='/search' className={navLinkClassName}>
                Search
              </NavLink>
            </li>
          </ul>
        </nav>
      </header>
    </>
  );
};

You might say that we can just map over array of links, as usual, but that again restricts us from building more complex and type safe logic

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 1d3b97a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 10, 2024

Hi @zeromask1337,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 10, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11
Copy link
Contributor

Thank you for the PR! Would you mind adding a changeset?

@zeromask1337
Copy link
Contributor Author

@brophdawg11 have I done it right?

@brophdawg11 brophdawg11 merged commit d73c1f6 into remix-run:dev Jun 18, 2024
3 checks passed
Copy link
Contributor

github-actions bot commented Jul 1, 2024

🤖 Hello there,

We just published version 6.24.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Jul 3, 2024

🤖 Hello there,

We just published version 6.24.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants