-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move server-runtime
into react-router
#11698
Move server-runtime
into react-router
#11698
Conversation
|
Name | Type |
---|---|
react-router | Major |
react-router-dom | Major |
@react-router/dev | Major |
@react-router/node | Major |
@react-router/express | Major |
@react-router/serve | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
env: { | ||
browser: true, | ||
commonjs: true, | ||
}, | ||
rules: { | ||
strict: 0, | ||
"no-restricted-syntax": ["error", "LogicalExpression[operator='??']"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just porting across equivalent config from .eslintrc
(removed above) since it was converted to .eslintrc.js
so it can include the options from the server-runtime
package.
@@ -1,4 +1,8 @@ | |||
import { parseMultipartFormData } from "../formData"; | |||
/** | |||
* @jest-environment node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed in a few tests since react-router
uses jsdom as its default environment, resulting in a few test failures when moving tests across.
// defer, | ||
// json, | ||
// redirect, | ||
// redirectDocument, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brophdawg11 What's the plan with these APIs? For now I've left the React Router versions as the exported implementations.
@@ -43,6 +43,7 @@ export interface EntryContext extends RemixContextObject { | |||
export interface FutureConfig { | |||
v3_fetcherPersist: boolean; | |||
v3_relativeSplatPath: boolean; | |||
v3_throwAbortReason: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag was in the server-runtime
implementation but missing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file previously contained and exported the following types:
EntryContext
FutureConfig
AssetsManifest
Instead, this PR updates server-runtime
to use the existing React Router types.
No description provided.