Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundle size check #11718

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

brophdawg11
Copy link
Contributor

This check as it stands is not helpful in the new v7 state of RR since our minified UMD bundles are much larger now that they incorporate the router, the DOM APIs, the Remix APIs etc. This is just a barrier to merging v7 PRs at the moment.

Once v7 stabilizes a bit more we can consider looking into re-adding a check of this type, but it should not be simply a minified file size check but instead be some form of check against a bundled/treeshaken application.

Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: 5b5abea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 merged commit 7ac021a into v7 Jun 24, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/remove-bundle-size-check branch June 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant