-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP route modules for defineRoute #11761
Conversation
|
@@ -42,6 +42,7 @@ import { | |||
resolvePublicPath, | |||
} from "../config"; | |||
import * as defineRoute from "./define-route"; | |||
import exp from "node:constants"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this got auto-imported accidentally, will remove
exports are only ever used on the server. Without this optimization we can't | ||
tree-shake any unused custom exports because routes are entry points. */ | ||
const BUILD_CLIENT_ROUTE_QUERY_STRING = "?__remix-build-client-route"; | ||
const ROUTE_ENTRY_QUERY_STRING = "?__react-router-entry=1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the query string can be prettier ala ?entry=true
or something since it doesn't affect URLs, just route module imports
obsoleted by #11762 |
No description provided.