Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic v7 template #12029

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Add basic v7 template #12029

merged 7 commits into from
Sep 24, 2024

Conversation

brookslybrand
Copy link
Contributor

@brookslybrand brookslybrand commented Sep 24, 2024

For now you can test with

npx degit remix-run/react-router/templates/basic#v7-template my-app 

Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: ba4be6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brookslybrand brookslybrand changed the base branch from main to dev September 24, 2024 16:51
@@ -0,0 +1,40 @@
# Welcome to React Router!

- 📖 [React Router docs](https://reactrouter.com/dev)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now I have everything pointing to /dev since this is all in the pre-release. We'll of course need to clean this up before the final release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link doesn't work, https://reactrouter.com/en/dev that one does it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergio! Yeah, the links are anticipating some changes to the react-router site. I'm planning to go through them all again before we release the prerelease

"@react-router/node": "0.0.0-nightly-8f12ed19a-20240924",
"@react-router/serve": "0.0.0-nightly-8f12ed19a-20240924",
"@tailwindcss/vite": "^4.0.0-alpha.24",
"isbot": "^5.1.17",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed a bunch of dependencies (like eslint). I don't know if isbot is a peer dep or what, but that's the only one I kept I wasn't sure about

Also moved to tailwind alpha since it removes a bunch of files and I imagine it'll be released before we release v7 official. If that's no the case that's fine, I'll just switch back

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isbot is used on the entry.server on Remix apps, I don't see that file here, is it removed? Or just hidden?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like eslint

Thank you. 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isbot is used on the entry.server on Remix apps, I don't see that file here, is it removed? Or just hidden?

Yeah, I removed entry.server and entry.client. This is how Remix worked, if they're not there a hidden version is automatically used.

We may add them back as default visible, I was just trying to make this super simple

"@react-router/node": "0.0.0-nightly-8f12ed19a-20240924",
"@react-router/serve": "0.0.0-nightly-8f12ed19a-20240924",
"@tailwindcss/vite": "^4.0.0-alpha.24",
"isbot": "^5.1.17",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like eslint

Thank you. 🙏

templates/basic/tailwind.config.ts Outdated Show resolved Hide resolved

### DIY

If you're familiar with deploying Node applications, the built-in app server is production-ready.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to deploy to CF already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we ported over the CF packages, so @react-router/cloudflare should work.

I haven't messed with it yet and I don't know if we have any documentation, however I'm not sure what if any breaking changes there are

brookslybrand and others added 5 commits September 24, 2024 16:29
Co-authored-by: Sergio Xalambrí <hello@sergiodxa.com>
Co-authored-by: Sergio Xalambrí <hello@sergiodxa.com>
@brookslybrand brookslybrand merged commit 190ba57 into dev Sep 24, 2024
5 checks passed
@brookslybrand brookslybrand deleted the v7-template branch September 24, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants