-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic v7 template #12029
Add basic v7 template #12029
Conversation
|
@@ -0,0 +1,40 @@ | |||
# Welcome to React Router! | |||
|
|||
- 📖 [React Router docs](https://reactrouter.com/dev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I have everything pointing to /dev
since this is all in the pre-release. We'll of course need to clean this up before the final release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link doesn't work, https://reactrouter.com/en/dev that one does it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sergio! Yeah, the links are anticipating some changes to the react-router site. I'm planning to go through them all again before we release the prerelease
"@react-router/node": "0.0.0-nightly-8f12ed19a-20240924", | ||
"@react-router/serve": "0.0.0-nightly-8f12ed19a-20240924", | ||
"@tailwindcss/vite": "^4.0.0-alpha.24", | ||
"isbot": "^5.1.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed a bunch of dependencies (like eslint). I don't know if isbot
is a peer dep or what, but that's the only one I kept I wasn't sure about
Also moved to tailwind alpha since it removes a bunch of files and I imagine it'll be released before we release v7 official. If that's no the case that's fine, I'll just switch back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isbot is used on the entry.server on Remix apps, I don't see that file here, is it removed? Or just hidden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like eslint
Thank you. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isbot is used on the entry.server on Remix apps, I don't see that file here, is it removed? Or just hidden?
Yeah, I removed entry.server
and entry.client
. This is how Remix worked, if they're not there a hidden version is automatically used.
We may add them back as default visible, I was just trying to make this super simple
"@react-router/node": "0.0.0-nightly-8f12ed19a-20240924", | ||
"@react-router/serve": "0.0.0-nightly-8f12ed19a-20240924", | ||
"@tailwindcss/vite": "^4.0.0-alpha.24", | ||
"isbot": "^5.1.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like eslint
Thank you. 🙏
|
||
### DIY | ||
|
||
If you're familiar with deploying Node applications, the built-in app server is production-ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to deploy to CF already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we ported over the CF packages, so @react-router/cloudflare
should work.
I haven't messed with it yet and I don't know if we have any documentation, however I'm not sure what if any breaking changes there are
Co-authored-by: Sergio Xalambrí <hello@sergiodxa.com>
Co-authored-by: Sergio Xalambrí <hello@sergiodxa.com>
Use Tailwind v4's CSS-based config
For now you can test with