chore(type): clarify the types are drived from the Agnostic types #12051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Hi there! It's my first contribution to this project :)
I understand that Agnostic is typed to be used universally, and the types are added and modified after inheriting it to fit the React environment.
At first, I was curious about the types, but as I looked through the list, I found it challenging to understand concepts such as whether they inherit from
Agnostic
, how much of the originalAgnostic
is carried over, whether all elements of Agnostic are included or only some are borrowed, and the differences betweenIndex
andNonIndex
. Of course, my lack of background knowledge contributes to this difficulty.Considering this, I thought that if it were clear in the types that they are defined after inheriting from
Agnostic
to fit the environment, it would be much easier to understand. So, I made some modifications based on that idea!IndexRouteObject, NonIndexRouteObject
PathRouteProps, IndexPathRouteProps
Test