[DO NOT MERGE] Use lazily-initialized shims for history singletons #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably more correct: remix-run/history#283 |
taion
changed the title
Current coverage is 95.01%@@ master #3388 diff @@
==========================================
Files 30 30
Lines 921 921
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 875 875
Misses 46 46
Partials 0 0
|
|
Erm. wat |
|
ALL HAIL THE GIANT GREEN CIRCLE OF COVERAGE! |
| 'createPath', | ||
| 'createHref', | ||
| 'createLocation' | ||
| ] |
There was a problem hiding this comment.
Really don't like this. I get that we're tied to the API internally anyways, but this seems like an antipattern to me. I would kill for a method_missing equivalent in JS, but that's not going to happen until Proxy is more prevalent.
There was a problem hiding this comment.
This isn't the right way to go about it anyway, the history PR is much better.
|
history 2.1.1 is out, so this shouldn't be needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe?
It'd address e.g. #3387.
Going to make a separate PR to history that makes the base href check lazy, which is probably more correct.