esModule: false fix read only TypeError in exports #6758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested from previous PR, any client exclusively using react-router-dom package via CommonJS modules will run into this problem:
Changing rollup config to omit
Object.defineProperty(exports, '__esModule', { value: true });
will fix this, however my suggestion in #6757 seems less heavy handed in that it doesn't break interop https://stackoverflow.com/a/55687758