Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash when <Link /> was used within <StaticRouter /> #7126

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Fix a crash when <Link /> was used within <StaticRouter /> #7126

merged 1 commit into from
Feb 5, 2020

Conversation

punmechanic
Copy link

This resolves #7124.

@punmechanic
Copy link
Author

I'm going to put that build step failure in the 'not my problem' box :-)

@MeiKatz
Copy link
Contributor

MeiKatz commented Feb 4, 2020

I'm going to put that build step failure in the 'not my problem' box :-)

And you are right about it

@timdorr
Copy link
Member

timdorr commented Feb 5, 2020

Thanks!

@timdorr timdorr merged commit 6d4236c into remix-run:dev Feb 5, 2020
@punmechanic punmechanic deleted the dev branch February 5, 2020 10:58
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@punmechanic @MeiKatz @timdorr