-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optional params and static segments #9650
Conversation
🦋 Changeset detectedLatest commit: afbcf9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @lordofthecactus, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Awesome! Thanks Daniel! Pedro will work with you to get this over the finish line. |
I think we should support
And the ranking should behave the same way. |
Agreed - this "exploding" approach (before scoring/ranking) is designed to do just that - behave as if the user manually exploded the enumerations out on their own 👍 |
Looks like CI is failing due to filesize limitations. @lordofthecactus , could you bump the |
@pcattori made the changes |
We gotta get @developit in here to shrink it all down again. |
Closes: #9550
Allows optional params and optional static segments
Optional params examples
:lang?/about
will get expanded matched with/multistep/:widget1?/widget2?/widget3?
Will get expanded matched with:
Same with static segments
/fr?/about
will get expanded and matched with:Context
Code was added at the point of
flattenRoutes
Feedback required
Should we allow intercalated situations? currently:
/one/:two?/three/four?
gets matched with: