Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create-remix missing peerDeps #3461

Closed
wants to merge 2 commits into from

Conversation

vovsemenv
Copy link

Testing Strategy:
just run pnpx create-remix and you will get this warnings

 WARN  Issues with peer dependencies found
.
└─┬ create-remix
  └─┬ @remix-run/dev
    ├─┬ @remix-run/server-runtime
    │ ├── ✕ missing peer react@>=16.8
    │ ├── ✕ missing peer react-dom@>=16.8
    │ └─┬ react-router-dom
    │   ├── ✕ missing peer react@>=16.8
    │   ├── ✕ missing peer react-dom@>=16.8
    │   └─┬ react-router
    │     └── ✕ missing peer react@>=16.8
    └─┬ jscodeshift
      └── ✕ missing peer @babel/preset-env@^7.1.6
Peer dependencies that should be installed:
  @babel/preset-env@^7.1.6  react-dom@>=16.8.0        react@>=16.8.0    

@babel/preset-env warnings was fixed by #3413
and this PR fix two other warnings

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 13, 2022

Hi @vovsemenv,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 13, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@vovsemenv
Copy link
Author

@MichaelDeBoey check this peerDeps problem pls

@machour machour requested a review from MichaelDeBoey June 13, 2022 19:39
@vovsemenv
Copy link
Author

 👉👈

@MichaelDeBoey
Copy link
Member

This is fixed by #4801

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants