Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add script for copying build output to package dist directories #3540

Merged
merged 14 commits into from
Jun 23, 2022

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Jun 22, 2022

This will be useful for publishing via Changesets. We can remove this once we've reconfigured Rollup accordingly.

@chaance chaance marked this pull request as draft June 22, 2022 18:55
@chaance chaance marked this pull request as ready for review June 23, 2022 17:09
@chaance
Copy link
Collaborator Author

chaance commented Jun 23, 2022

@mcansh Any clue why we'd suddenly be running out of memory in CI? I don't feel like anything has substantially changed about the build other than including the Rollup TS plugin, and I have no such issues w/ Node's default memory limit running locally.

@mcansh
Copy link
Collaborator

mcansh commented Jun 23, 2022

@mcansh Any clue why we'd suddenly be running out of memory in CI? I don't feel like anything has substantially changed about the build other than including the Rollup TS plugin, and I have no such issues w/ Node's default memory limit running locally.

nothing's jumping out at me, but i can take a look

@mcansh
Copy link
Collaborator

mcansh commented Jun 23, 2022

the new build does use almost 3GB of memory though, where as the old one used less than 1GB, so it might be related

however according to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources they should have 7GB of memory, but im not sure how much of that is actually usable

@brophdawg11 brophdawg11 self-assigned this Jun 23, 2022
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds looked ok to me locally. Think it's worth publishing an experimental from here and actually npm installing a few things to make sure it all looks good?

@brophdawg11 brophdawg11 removed their assignment Jun 23, 2022
@chaance
Copy link
Collaborator Author

chaance commented Jun 23, 2022

@brophdawg11 Successfully tested with npx create-remix@0.0.0-experimental-c5bb5cb31. If you want to spin it up you'll need to force install to deal w/ peer deps (need to fix that in the version script), but should be good to go.

@chaance chaance merged commit 0f8279d into dev Jun 23, 2022
@chaance chaance deleted the chance/copy-dist branch June 23, 2022 21:45
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-dec8a6d-20220624 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@federicoestevez federicoestevez mentioned this pull request Jul 2, 2022
2 tasks
@federicoestevez federicoestevez mentioned this pull request Jul 2, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants