Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(remix-dev): Optimize parentRouteId lookup in defineConventionalRoutes #4538

Merged
merged 4 commits into from
Dec 7, 2022
Merged

perf(remix-dev): Optimize parentRouteId lookup in defineConventionalRoutes #4538

merged 4 commits into from
Dec 7, 2022

Commits on Dec 7, 2022

  1. Use object for parentRouteId lookup

    @dmarkow
    dmarkow committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    6ccc711 View commit details
    Browse the repository at this point in the history

  2. Sign CLA

    @dmarkow
    dmarkow committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b26c64b View commit details
    Browse the repository at this point in the history

  3. Move parentRouteId logic to a separate function

    @dmarkow
    dmarkow committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    8fd46fc View commit details
    Browse the repository at this point in the history

  4. Update test fixture path

    @dmarkow
    dmarkow committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    d708702 View commit details
    Browse the repository at this point in the history