Remove instanceof Response checks in favor of isResponse #4782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2ac118 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Dec 6, 2022
| @@ -103,5 +124,12 @@ test.describe("loader in an app", () => { | |||
| let app = new PlaywrightFixture(appFixture, page); | |||
| await app.goto("/redirect"); | |||
| expect(await app.getHtml()).toMatch(HOME_PAGE_TEXT); | |||
| expect(await app.getHtml()).toMatch(REDIRECT_TARGET_TEXT); | |||
There was a problem hiding this comment.
Strengthened the existing redirect tests a bit to ensure it renders the right content at the redirected location.
brophdawg11
commented
Dec 6, 2022
| `, | ||
| "app/routes/fetch.jsx": js` | ||
| export function loader({ request }) { | ||
| return fetch(new URL(request.url).origin + '/fetch-target'); |
There was a problem hiding this comment.
This is the case we're fixing here - returning a raw fetch Response wasn't matching our instanceof Response check
kentcdodds
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Remove instanceof Response checks in favor of isResponse * Add changeset * Bump to @remix-run/router 1.0.5-pre.1
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4741 by using
isResponseinstead ofinstanceof ResponseNote: integration tests will fail until we get
@remix-run/server-runtimeonto the latest@remix-run/router