Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defer - for real this time #4920

Merged
merged 9 commits into from
Jan 13, 2023
Merged

defer - for real this time #4920

merged 9 commits into from
Jan 13, 2023

Conversation

jacob-ebey
Copy link
Member

@jacob-ebey jacob-ebey commented Dec 20, 2022 •
edited
Loading

Relies on: remix-run/react-router#9760

Closes: #4486

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 2383994

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
remix Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacob-ebey jacob-ebey mentioned this pull request Dec 20, 2022
Closed
5 tasks
@brophdawg11 brophdawg11 changed the title initial work for document requests defer - initial work for document requests Dec 21, 2022
brophdawg11
brophdawg11 reviewed Dec 21, 2022
View reviewed changes
packages/remix-react/components.tsx Outdated
let { matches } = useDataRouterStateContext();
let staticContext = React.useContext(DataStaticRouterContext);
Copy link
Contributor

@brophdawg11 brophdawg11 Dec 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have to be defensive on staticContext anyway, should we just const isStatic = staticContext != null?

@jacob-ebey jacob-ebey changed the title defer - initial work for document requests defer - for real this time Dec 22, 2022
@jacob-ebey jacob-ebey marked this pull request as ready for review January 11, 2023 20:47
@jacob-ebey jacob-ebey merged commit be232a0 into dev Jan 13, 2023
@jacob-ebey jacob-ebey deleted the rrr-defer branch January 13, 2023 23:35
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 13, 2023
@mcansh mcansh mentioned this pull request Jan 13, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.11.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d593e4a-20230114 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@mcansh mcansh mentioned this pull request Jan 18, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.11.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

Assignees
No one assigned
Labels
CLA Signed feat:deferred feat:routing package:server-runtime package:testing renderer:react runtime:cloudflare runtime:deno runtime:node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacob-ebey @brophdawg11 @MichaelDeBoey