Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev): show deprecation warning when serverBuildDirectory config is used #5704

Conversation

MichaelDeBoey
Copy link
Member

This will warn people about #5703

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

🦋 Changeset detected

Latest commit: 653a6d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
create-remix Minor
@remix-run/css-bundle Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the show-deprecation-message-for-serverBuildDirectory-config branch from ec277e8 to e933a19 Compare March 8, 2023 00:38
@MichaelDeBoey MichaelDeBoey force-pushed the show-deprecation-message-for-serverBuildDirectory-config branch 2 times, most recently from e792cdb to b2d98ff Compare March 15, 2023 11:05
@MichaelDeBoey MichaelDeBoey force-pushed the show-deprecation-message-for-serverBuildDirectory-config branch from f942f81 to 653a6d3 Compare March 15, 2023 22:25
@jacob-ebey jacob-ebey merged commit 4b70f9f into remix-run:dev Mar 15, 2023
@MichaelDeBoey MichaelDeBoey deleted the show-deprecation-message-for-serverBuildDirectory-config branch March 15, 2023 23:46
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-4b70f9f-20230316 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

fernandojbf pushed a commit to fernandojbf/remix that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants